In the Linux kernel, the following vulnerability has been resolved:
net: vlan: fix underflow for the real_dev refcnt
Inject error before devhold(realdev) in registervlandev(), and execute the following testcase:
ip link add dev dummy1 type dummy ip link add name dummy1.100 link dummy1 type vlan id 100 ip link del dev dummy1
When the dummy netdevice is removed, we will get a WARNING as following:
======================================================================= refcountt: decrement hit 0; leaking memory. WARNING: CPU: 2 PID: 0 at lib/refcount.c:31 refcountwarn_saturate+0xbf/0x1e0
and an endless loop of:
======================================================================= unregister_netdevice: waiting for dummy1 to become free. Usage count = -1073741824
That is because devput(realdev) in vlandevfree() be called without devhold(realdev) in registervlandev(). It makes the refcnt of real_dev underflow.
Move the devhold(realdev) to vlandevinit() which is the call-back of ndoinit(). That makes devhold() and devput() for vlan's realdev symmetrical.