In the Linux kernel, the following vulnerability has been resolved:
tracing/histograms: Fix memory leak problem
This reverts commit 46bbe5c671e06f070428b9be142cc4ee5cedebac.
As commit 46bbe5c671e0 ("tracing: fix double free") said, the "double free" problem reported by clang static analyzer is:
In parsevardefs() if there is a problem allocating vardefs.expr, the earlier vardefs.name is freed. This free is duplicated by freevardefs() which frees the rest of the list.
However, if there is a problem allocating N-th vardefs.expr: + in parsevardefs(), the freed 'earlier vardefs.name' is actually the N-th vardefs.name; + then in freevar_defs(), the names from 0th to (N-1)-th are freed;
IF ALLOCATING PROBLEM HAPPENED HERE!!! -+
\
|
0th 1th (N-1)-th N-th V
+-------------+-------------+-----+-------------+-----------
var_defs: | name | expr | name | expr | ... | name | expr | name | /// +-------------+-------------+-----+-------------+-----------
These two frees don't act on same name, so there was no "double free" problem before. Conversely, after that commit, we get a "memory leak" problem because the above "N-th var_defs.name" is not freed.
If enable CONFIGDEBUGKMEMLEAK and inject a fault at where the N-th vardefs.expr allocated, then execute on shell like: $ echo 'hist:key=callsite:val=$v1,$v2:v1=bytesreq,v2=bytesalloc' > \ /sys/kernel/debug/tracing/events/kmem/kmalloc/trigger
Then kmemleak reports: unreferenced object 0xffff8fb100ef3518 (size 8): comm "bash", pid 196, jiffies 4295681690 (age 28.538s) hex dump (first 8 bytes): 76 31 00 00 b1 8f ff ff v1...... backtrace: [<0000000038fe4895>] kstrdup+0x2d/0x60 [<00000000c99c049a>] eventhisttriggerparse+0x206f/0x20e0 [<00000000ae70d2cc>] triggerprocessregex+0xc0/0x110 [<0000000066737a4c>] eventtriggerwrite+0x75/0xd0 [<000000007341e40c>] vfswrite+0xbb/0x2a0 [<0000000087fde4c2>] ksyswrite+0x59/0xd0 [<00000000581e9cdf>] dosyscall64+0x3a/0x80 [<00000000cf3b065c>] entrySYSCALL64after_hwframe+0x46/0xb0
{ "vanir_signatures": [ { "deprecated": false, "id": "CVE-2022-49648-1004b5e2", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "280632775560850002071136689167843497344", "length": 1062.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@22eeff55679d9e7c0f768c79bfbd83e2f8142d89", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-16781af0", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@7edc3945bdce9c39198a10d6129377a5c53559c2", "signature_type": "Line" }, { "deprecated": false, "id": "CVE-2022-49648-1835eaf5", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "280632775560850002071136689167843497344", "length": 1062.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@7edc3945bdce9c39198a10d6129377a5c53559c2", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-28df19f5", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "280632775560850002071136689167843497344", "length": 1062.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@78a1400c42ee11197eb1f0f85ba51df9a4fdfff0", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-2c401840", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "280632775560850002071136689167843497344", "length": 1062.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@4d453eb5e1eec89971aa5b3262857ee26cfdffd3", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-3a70d9fa", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@22eeff55679d9e7c0f768c79bfbd83e2f8142d89", "signature_type": "Line" }, { "deprecated": false, "id": "CVE-2022-49648-46e4e263", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "280632775560850002071136689167843497344", "length": 1062.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ecc6dec12c33aa92c086cd702af9f544ddaf3c75", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-b0f5d375", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@eb622d5580b9e2ff694f62da6410618bd73853cb", "signature_type": "Line" }, { "deprecated": false, "id": "CVE-2022-49648-bb023288", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@78a1400c42ee11197eb1f0f85ba51df9a4fdfff0", "signature_type": "Line" }, { "deprecated": false, "id": "CVE-2022-49648-bba106ee", "target": { "file": "kernel/trace/trace_events_hist.c", "function": "parse_var_defs" }, "signature_version": "v1", "digest": { "function_hash": "281620063474310569203541903805048596517", "length": 984.0 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@eb622d5580b9e2ff694f62da6410618bd73853cb", "signature_type": "Function" }, { "deprecated": false, "id": "CVE-2022-49648-ccbd6b3a", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ecc6dec12c33aa92c086cd702af9f544ddaf3c75", "signature_type": "Line" }, { "deprecated": false, "id": "CVE-2022-49648-fd8395dd", "target": { "file": "kernel/trace/trace_events_hist.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "146177123629209043430506519316591397060", "319278372210582158274729304297867569926", "17761350950475082814333273010478288111", "244128949517333667565038862188524661444" ], "threshold": 0.9 }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@4d453eb5e1eec89971aa5b3262857ee26cfdffd3", "signature_type": "Line" } ] }