In the Linux kernel, the following vulnerability has been resolved:
block, bfq: fix possible uaf for 'bfqq->bic'
Our test report a uaf for 'bfqq->bic' in 5.10:
================================================================== BUG: KASAN: use-after-free in bfqselectqueue+0x378/0xa30
CPU: 6 PID: 2318352 Comm: fsstress Kdump: loaded Not tainted 5.10.0-60.18.0.50.h602.kasan.eulerosv2r11.x8664 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.1-0-ga5cab58-20220320160524-szxrtosci10000 04/01/2014 Call Trace: bfqselectqueue+0x378/0xa30 bfqdispatchrequest+0xe8/0x130 blkmqdodispatchsched+0x62/0xb0 _blkmqscheddispatchrequests+0x215/0x2a0 blkmqscheddispatchrequests+0x8f/0xd0 _blkmqrunhwqueue+0x98/0x180 _blkmqdelayrunhwqueue+0x22b/0x240 blkmqrunhwqueue+0xe3/0x190 blkmqschedinsertrequests+0x107/0x200 blkmqflushpluglist+0x26e/0x3c0 blkfinishplug+0x63/0x90 _iomapdiorw+0x7b5/0x910 iomapdiorw+0x36/0x80 ext4dioreaditer+0x146/0x190 [ext4] ext4filereaditer+0x1e2/0x230 [ext4] newsyncread+0x29f/0x400 vfsread+0x24e/0x2d0 ksysread+0xd5/0x1b0 dosyscall64+0x33/0x40 entrySYSCALL64after_hwframe+0x61/0xc6
Commit 3bc5e683c67d ("bfq: Split shared queues on move between cgroups") changes that move process to a new cgroup will allocate a new bfqq to use, however, the old bfqq and new bfqq can point to the same bic:
1) Initial state, two process with io in the same cgroup.
Process 1 Process 2 (BIC1) (BIC2) | Λ | Λ | | | | V | V | bfqq1 bfqq2
2) bfqq1 is merged to bfqq2.
Process 1 Process 2 (BIC1) (BIC2) | | -------------\| V bfqq1 bfqq2(coop)
3) Process 1 exit, then issue new io(denoce IOA) from Process 2.
(BIC2) | Λ | | V | bfqq2(coop)
4) Before IOA is completed, move Process 2 to another cgroup and issue io.
Process 2 (BIC2) Λ |--------------\ | V bfqq2 bfqq3
Now that BIC2 points to bfqq3, while bfqq2 and bfqq3 both point to BIC2. If all the requests are completed, and Process 2 exit, BIC2 will be freed while there is no guarantee that bfqq2 will be freed before BIC2.
Fix the problem by clearing bfqq->bic while bfqq is detached from bic.
[
{
"signature_type": "Function",
"digest": {
"function_hash": "30850569564203077326271752176271020541",
"length": 101.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bic_set_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5533742c7cb1bc9b1f0bf401cc397d44a3a9e07a",
"id": "CVE-2022-50488-072dc0de",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "113914107174543046607528674457018308816",
"length": 340.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bfq_exit_icq_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5533742c7cb1bc9b1f0bf401cc397d44a3a9e07a",
"id": "CVE-2022-50488-0f012852",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"86383836956356689591990631582312767030",
"206026445167786908628348645835760033557",
"37329900271913877070996173733239721671",
"90267810151155641976163556717045860379",
"330185720404431491591639589159727271947",
"140751349508987032097686909778425615415",
"233782154540459927961667928446678013072",
"9031226830094331773366739045132789015"
]
},
"target": {
"file": "block/bfq-iosched.c"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@094f3d9314d67691cb21ba091c1b528f6e3c4893",
"id": "CVE-2022-50488-17f76b62",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "113914107174543046607528674457018308816",
"length": 340.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bfq_exit_icq_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@761564d93c8265f65543acf0a576b32d66bfa26a",
"id": "CVE-2022-50488-1cca2365",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"197643463064357033857949975727172536874",
"46891368285623569665940002198598099671",
"218030754781923991344884028362558760890",
"81231344089829299666265302654811939683",
"330185720404431491591639589159727271947",
"140751349508987032097686909778425615415",
"233782154540459927961667928446678013072",
"9031226830094331773366739045132789015"
]
},
"target": {
"file": "block/bfq-iosched.c"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5533742c7cb1bc9b1f0bf401cc397d44a3a9e07a",
"id": "CVE-2022-50488-227dc30e",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "319777700973650443043709025077629458479",
"length": 235.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bic_set_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b22fd72bfebda3956efc4431b60ddfc0a51e03e0",
"id": "CVE-2022-50488-2e4a8f39",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "319777700973650443043709025077629458479",
"length": 235.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bic_set_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@761564d93c8265f65543acf0a576b32d66bfa26a",
"id": "CVE-2022-50488-3efe2def",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"86383836956356689591990631582312767030",
"206026445167786908628348645835760033557",
"37329900271913877070996173733239721671",
"90267810151155641976163556717045860379",
"330185720404431491591639589159727271947",
"140751349508987032097686909778425615415",
"233782154540459927961667928446678013072",
"9031226830094331773366739045132789015"
]
},
"target": {
"file": "block/bfq-iosched.c"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@64dc8c732f5c2b406cc752e6aaa1bd5471159cab",
"id": "CVE-2022-50488-509cbaad",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "113914107174543046607528674457018308816",
"length": 340.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bfq_exit_icq_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@094f3d9314d67691cb21ba091c1b528f6e3c4893",
"id": "CVE-2022-50488-61229c4f",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"86383836956356689591990631582312767030",
"206026445167786908628348645835760033557",
"37329900271913877070996173733239721671",
"90267810151155641976163556717045860379",
"330185720404431491591639589159727271947",
"140751349508987032097686909778425615415",
"233782154540459927961667928446678013072",
"9031226830094331773366739045132789015"
]
},
"target": {
"file": "block/bfq-iosched.c"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b22fd72bfebda3956efc4431b60ddfc0a51e03e0",
"id": "CVE-2022-50488-6bd20416",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "319777700973650443043709025077629458479",
"length": 235.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bic_set_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@64dc8c732f5c2b406cc752e6aaa1bd5471159cab",
"id": "CVE-2022-50488-8502e9b3",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "113914107174543046607528674457018308816",
"length": 340.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bfq_exit_icq_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@64dc8c732f5c2b406cc752e6aaa1bd5471159cab",
"id": "CVE-2022-50488-90a0d81c",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"86383836956356689591990631582312767030",
"206026445167786908628348645835760033557",
"37329900271913877070996173733239721671",
"90267810151155641976163556717045860379",
"330185720404431491591639589159727271947",
"140751349508987032097686909778425615415",
"233782154540459927961667928446678013072",
"9031226830094331773366739045132789015"
]
},
"target": {
"file": "block/bfq-iosched.c"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@761564d93c8265f65543acf0a576b32d66bfa26a",
"id": "CVE-2022-50488-bb5f6c9c",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "113914107174543046607528674457018308816",
"length": 340.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bfq_exit_icq_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b22fd72bfebda3956efc4431b60ddfc0a51e03e0",
"id": "CVE-2022-50488-d282b942",
"deprecated": false,
"signature_version": "v1"
},
{
"signature_type": "Function",
"digest": {
"function_hash": "319777700973650443043709025077629458479",
"length": 235.0
},
"target": {
"file": "block/bfq-iosched.c",
"function": "bic_set_bfqq"
},
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@094f3d9314d67691cb21ba091c1b528f6e3c4893",
"id": "CVE-2022-50488-e6797d19",
"deprecated": false,
"signature_version": "v1"
}
]