GHSA-mh8j-9jvh-gjf6

Suggest an improvement
Source
https://github.com/advisories/GHSA-mh8j-9jvh-gjf6
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/12/GHSA-mh8j-9jvh-gjf6/GHSA-mh8j-9jvh-gjf6.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-mh8j-9jvh-gjf6
Aliases
  • CVE-2023-26158
Published
2023-12-08T06:30:38Z
Modified
2023-12-08T16:11:28.865673Z
Severity
  • 8.2 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:H CVSS Calculator
Summary
mockjs vulnerable to Prototype Pollution via the Util.extend function
Details

All versions of the package mockjs are vulnerable to Prototype Pollution via the Util.extend function due to missing check if the attribute resolves to the object prototype. By adding or modifying attributes of an object prototype, it is possible to create attributes that exist on every object, or replace critical attributes with malicious ones. This can be problematic if the software depends on existence or non-existence of certain attributes, or uses pre-defined attributes of object prototype (such as hasOwnProperty, toString or valueOf).

User controlled inputs inside the extend() method of the Mock.Handler, Mock.Random, Mock.RE.Handler or Mock.Util, will allow an attacker to exploit this vulnerability.

Workaround

By using a denylist of dangerous attributes, this weakness can be eliminated.

Add the following line in the Util.extend function:

js js if (["proto", "constructor", "prototype"].includes(name)) continue

js // src/mock/handler.js Util.extend = function extend() { var target = arguments[0] || {}, i = 1, length = arguments.length, options, name, src, copy, clone

    if (length === 1) {
        target = this
        i = 0
    }

    for (; i < length; i++) {
        options = arguments[i]
        if (!options) continue

        for (name in options) {
        if (["__proto__", "constructor", "prototype"].includes(name)) continue
            src = target[name]
            copy = options[name]

            if (target === copy) continue
            if (copy === undefined) continue

            if (Util.isArray(copy) || Util.isObject(copy)) {
                if (Util.isArray(copy)) clone = src && Util.isArray(src) ? src : []
                if (Util.isObject(copy)) clone = src && Util.isObject(src) ? src : {}

                target[name] = Util.extend(clone, copy)
            } else {
                target[name] = copy
            }
        }
    }

    return target
}
Database specific
{
    "github_reviewed_at": "2023-12-08T15:49:13Z",
    "github_reviewed": true,
    "severity": "HIGH",
    "nvd_published_at": "2023-12-08T05:15:07Z",
    "cwe_ids": [
        "CWE-1321"
    ]
}
References

Affected packages

npm / mockjs

Package

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Last affected
1.1.0

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/12/GHSA-mh8j-9jvh-gjf6/GHSA-mh8j-9jvh-gjf6.json"