In the Linux kernel, the following vulnerability has been resolved:
usb: gadget: fncm: fix potential NULL ptr deref in ncmbitrate()
In Google internal bug 265639009 we've received an (as yet) unreproducible crash report from an aarch64 GKI 5.10.149-android13 running device.
AFAICT the source code is at: https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2022-12-05_13-5.10
The call stack is: ncmclose() -> ncmnotify() -> ncmdonotify() with the crash at: ncmdonotify+0x98/0x270 Code: 79000d0b b9000a6c f940012a f9400269 (b9405d4b)
Which I believe disassembles to (I don't know ARM assembly, but it looks sane enough to me...):
// halfword (16-bit) store presumably to event->wLength (at offset 6 of struct usbcdcnotification) 0B 0D 00 79 strh w11, [x8, #6]
// word (32-bit) store presumably to req->Length (at offset 8 of struct usb_request) 6C 0A 00 B9 str w12, [x19, #8]
// x10 (NULL) was read here from offset 0 of valid pointer x9 // IMHO we're reading 'cdev->gadget' and getting NULL // gadget is indeed at offset 0 of struct usbcompositedev 2A 01 40 F9 ldr x10, [x9]
// loading req->buf pointer, which is at offset 0 of struct usb_request 69 02 40 F9 ldr x9, [x19]
// x10 is null, crash, appears to be attempt to read cdev->gadget->max_speed 4B 5D 40 B9 ldr w11, [x10, #0x5c]
which seems to line up with ncmdonotify() case NCMNOTIFYSPEED code fragment:
event->wLength = cputole16(8); req->length = NCMSTATUSBYTECOUNT;
/* SPEEDCHANGE data is up/down speeds in bits/sec */ data = req->buf + sizeof *event; data[0] = cputole32(ncmbitrate(cdev->gadget));
My analysis of registers and NULL ptr deref crash offset (Unable to handle kernel NULL pointer dereference at virtual address 000000000000005c) heavily suggests that the crash is due to 'cdev->gadget' being NULL when executing: data[0] = cputole32(ncmbitrate(cdev->gadget)); which calls: ncmbitrate(NULL) which then calls: gadgetissuperspeed(NULL) which reads ((struct usbgadget *)NULL)->maxspeed and hits a panic.
AFAICT, if I'm counting right, the offset of maxspeed is indeed 0x5C. (remember there's a GKI KABI reservation of 16 bytes in struct workstruct)
It's not at all clear to me how this is all supposed to work... but returning 0 seems much better than panic-ing...
[ { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c6ec929595c7443250b2a4faea988c62019d5cd2", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-18c96247", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@63d161f29cd39c050e8873aa36e0c9fc013bb763", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-33116a7b", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@09e4507ec8ef2d44da6ba4092b8ee2d81f216497", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-68abdd81", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a21da7f7aae618c785f7e4a275d43c06dc8412b6", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-6930dcd8", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@63d161f29cd39c050e8873aa36e0c9fc013bb763", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-994a4b56", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a21da7f7aae618c785f7e4a275d43c06dc8412b6", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-acf8a254", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a69c8dfb85b44be9cc223be07d35cc3a9baefbea", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-b9f6b330", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e92c70059178da751e5af7de02384b7dfadb5ec7", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-bd39a0f9", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fef6b29671b66dfb71f17e337c1ad14b5a2cedae", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-ceb80cfc", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e92c70059178da751e5af7de02384b7dfadb5ec7", "target": { "function": "ncm_bitrate", "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-d2b3e6d7", "deprecated": false, "signature_version": "v1", "digest": { "function_hash": "14987030626129999313413992224198330037", "length": 374.0 }, "signature_type": "Function" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a69c8dfb85b44be9cc223be07d35cc3a9baefbea", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-dc39930f", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@09e4507ec8ef2d44da6ba4092b8ee2d81f216497", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-e8ee4272", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c6ec929595c7443250b2a4faea988c62019d5cd2", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-edbb47e3", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fef6b29671b66dfb71f17e337c1ad14b5a2cedae", "target": { "file": "drivers/usb/gadget/function/f_ncm.c" }, "id": "CVE-2023-52894-f8e970d6", "deprecated": false, "signature_version": "v1", "digest": { "line_hashes": [ "254885079293299494702206365534378223293", "211090851825146856562093113473520302077", "316847508616502289926117007030872077475", "101877075895887696731222865682017746637" ], "threshold": 0.9 }, "signature_type": "Line" } ]