In the Linux kernel, the following vulnerability has been resolved:
cdrom: rearrange lastmediachange check to avoid unintentional overflow
When running syzkaller with the newly reintroduced signed integer wrap sanitizer we encounter this splat:
[ 366.015950] UBSAN: signed-integer-overflow in ../drivers/cdrom/cdrom.c:2361:33 [ 366.021089] -9223372036854775808 - 346321 cannot be represented in type '_s64' (aka 'long long') [ 366.025894] program syz-executor.4 is using a deprecated SCSI ioctl, please convert it to SGIO [ 366.027502] CPU: 5 PID: 28472 Comm: syz-executor.7 Not tainted 6.8.0-rc2-00035-gb3ef86b5a957 #1 [ 366.027512] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 366.027518] Call Trace: [ 366.027523] <TASK> [ 366.027533] dumpstacklvl+0x93/0xd0 [ 366.027899] handleoverflow+0x171/0x1b0 [ 366.038787] ata1.00: invalid multicount 32 ignored [ 366.043924] cdromioctl+0x2c3f/0x2d10 [ 366.063932] ? _pmruntimeresume+0xe6/0x130 [ 366.071923] srblockioctl+0x15d/0x1d0 [ 366.074624] ? _pfxsrblockioctl+0x10/0x10 [ 366.077642] blkdevioctl+0x419/0x500 [ 366.080231] ? _pfxblkdevioctl+0x10/0x10 ...
Historically, the signed integer overflow sanitizer did not work in the
kernel due to its interaction with -fwrapv
but this has since been
changed [1] in the newest version of Clang. It was re-enabled in the
kernel with Commit 557f8c582a9ba8ab ("ubsan: Reintroduce signed overflow
sanitizer").
Let's rearrange the check to not perform any arithmetic, thus not tripping the sanitizer.
[ { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@efb905aeb44b0e99c0e6b07865b1885ae0471ebf", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c" }, "digest": { "line_hashes": [ "101725929294684902090191809233033982668", "14378757641491435132180661797633749787", "82590320730627682872703125166992071295", "156289561320420594418610972391375566120" ], "threshold": 0.9 }, "deprecated": false, "signature_type": "Line", "id": "CVE-2024-42136-0ddb785b" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e809bc112712da8f7e15822674c6562da6cdf24c", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c" }, "digest": { "line_hashes": [ "101725929294684902090191809233033982668", "14378757641491435132180661797633749787", "82590320730627682872703125166992071295", "156289561320420594418610972391375566120" ], "threshold": 0.9 }, "deprecated": false, "signature_type": "Line", "id": "CVE-2024-42136-228a2b86" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@efb905aeb44b0e99c0e6b07865b1885ae0471ebf", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c", "function": "cdrom_ioctl_timed_media_change" }, "digest": { "length": 673.0, "function_hash": "283722687327681355958302304575922737524" }, "deprecated": false, "signature_type": "Function", "id": "CVE-2024-42136-3b33ab54" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3ee21e14c8c329168a0b66bab00ecd18f5d0dee3", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c" }, "digest": { "line_hashes": [ "101725929294684902090191809233033982668", "14378757641491435132180661797633749787", "82590320730627682872703125166992071295", "156289561320420594418610972391375566120" ], "threshold": 0.9 }, "deprecated": false, "signature_type": "Line", "id": "CVE-2024-42136-448370b1" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3ee21e14c8c329168a0b66bab00ecd18f5d0dee3", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c", "function": "cdrom_ioctl_timed_media_change" }, "digest": { "length": 673.0, "function_hash": "283722687327681355958302304575922737524" }, "deprecated": false, "signature_type": "Function", "id": "CVE-2024-42136-48bc7fe3" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e809bc112712da8f7e15822674c6562da6cdf24c", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c", "function": "cdrom_ioctl_timed_media_change" }, "digest": { "length": 673.0, "function_hash": "283722687327681355958302304575922737524" }, "deprecated": false, "signature_type": "Function", "id": "CVE-2024-42136-6e69a535" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0c97527e916054acc4a46ffb02842988acb2e92b", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c", "function": "cdrom_ioctl_timed_media_change" }, "digest": { "length": 673.0, "function_hash": "283722687327681355958302304575922737524" }, "deprecated": false, "signature_type": "Function", "id": "CVE-2024-42136-800aade0" }, { "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0c97527e916054acc4a46ffb02842988acb2e92b", "signature_version": "v1", "target": { "file": "drivers/cdrom/cdrom.c" }, "digest": { "line_hashes": [ "101725929294684902090191809233033982668", "14378757641491435132180661797633749787", "82590320730627682872703125166992071295", "156289561320420594418610972391375566120" ], "threshold": 0.9 }, "deprecated": false, "signature_type": "Line", "id": "CVE-2024-42136-d5310ef1" } ]