GHSA-27wg-99g8-2v4v

Suggest an improvement
Source
https://github.com/advisories/GHSA-27wg-99g8-2v4v
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/01/GHSA-27wg-99g8-2v4v/GHSA-27wg-99g8-2v4v.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-27wg-99g8-2v4v
Aliases
Published
2024-01-03T21:48:34Z
Modified
2024-01-03T22:11:29.598620Z
Severity
  • 5.9 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:H/A:N CVSS Calculator
Summary
Rust EVM erroneousle handles `record_external_operation` error return
Details

Impact

In rust-evm, a feature called record_external_operation was introduced, allowing library users to record custom gas changes. This feature can have some bogus interactions with the call stack.

In particular, during finalization of a CREATE or CREATE2, in the case that the substack execution happens successfully, rust-evm will first commit the substate, and then call record_external_operation(Write(out_code.len())). If record_external_operation later fails, this error is returned to the parent call stack, instead of Succeeded. Yet, the substate commitment already happened. This causes smart contracts able to commit state changes, when the parent caller contract receives zero address (which usually indicates that the execution has failed).

This issue only impacts library users with custom record_external_operation that returns errors.

Patches

The issue is patched in release 0.41.1. The commit can be seem here.

Workarounds

None.

References

Patch PR #264.

Database specific
{
    "nvd_published_at": "2024-01-02T22:15:09Z",
    "cwe_ids": [
        "CWE-703"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2024-01-03T21:48:34Z"
}
References

Affected packages

crates.io / evm

Package

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
0.41.1

Database specific

{
    "last_known_affected_version_range": "<= 0.41.0"
}