GHSA-3227-r97m-8j95

Suggest an improvement
Source
https://github.com/advisories/GHSA-3227-r97m-8j95
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/04/GHSA-3227-r97m-8j95/GHSA-3227-r97m-8j95.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-3227-r97m-8j95
Published
2022-04-22T20:16:45Z
Modified
2022-04-22T20:16:45Z
Summary
Relative Path Traversal in afire serve_static
Details

Impact

This vulnerability effects the built-in afire serve_static extension allowing paths containing //.... to bypass the previous path sanitation and request files in higher directories that should not be accessible.

Patches

The issue has been fixed in afire 1.1.0. If you can, just update to the newest version of afire.

Workarounds

If you can't update afire you can simply disallow paths containing /.. with the following middleware. Make sure this is the last middleware added to the server so it runs first, stopping the bad requests.

use afire::prelude::*;

struct PathTraversalFix;

impl Middleware for PathTraversalFix {
    fn pre(&self, req: Request) -> MiddleRequest {
        if req.path.replace("\\", "/").contains("/..") {
            return MiddleRequest::Send(
                Response::new()
                    .status(400)
                    .text("Paths containing `..` are not allowed"),
            );
        }

        MiddleRequest::Continue
    }
}
let mut server = Server::new(host, port);
PathTraversalFix.attach(&mut server);

References

You can read about the new changes to afire in 1.1.0 here

For more information

If you have any questions or comments about this advisory you can email me or message me on discord. [https://connorcode.com/contact]

Database specific
{
    "nvd_published_at": null,
    "cwe_ids": [
        "CWE-22",
        "CWE-34"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2022-04-22T20:16:45Z"
}
References

Affected packages

crates.io / afire

Package

Affected ranges

Type
SEMVER
Events
Introduced
0.2.1
Fixed
1.1.0