GHSA-3h6w-xcw3-9xjj

Suggest an improvement
Source
https://github.com/advisories/GHSA-3h6w-xcw3-9xjj
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-3h6w-xcw3-9xjj/GHSA-3h6w-xcw3-9xjj.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-3h6w-xcw3-9xjj
Aliases
Published
2026-11-20T14:56:58Z
Modified
2026-11-20T15:15:03Z
Severity
  • 6.3 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N CVSS Calculator
Summary
OpenRemote: Cross-realm MQTT session disconnect without authorization
Details

Summary

Cross-realm MQTT session disconnect without authorization

Vulnerability

The disconnectUserSession endpoint in UserResourceImpl.java (line 443) accepts a realm path parameter but ignores it entirely, performing no authorization or realm-boundary check before force-disconnecting an MQTT session. Any authenticated user from any realm can disconnect MQTT broker sessions belonging to users in other realms by supplying the target session ID.

File: manager/src/main/java/org/openremote/manager/security/UserResourceImpl.java, lines 443-447

@Override
public void disconnectUserSession(RequestParams requestParams, String realm, String sessionID) {
    if (!mqttBrokerService.disconnectSession(sessionID)) {
        throw new NotFoundException("User session not found");
    }
}

The REST interface at model/src/main/java/org/openremote/model/security/UserResource.java (line 201-204) maps this to GET {realm}/disconnect/{sessionID} with no @RolesAllowed annotation, so any authenticated user (not just admins) can call it.

Root Cause

CVE-2026-54641 (commit de89b8d) fixed cross-realm information disclosure in three read methods of the same file (get(), getUserClientRoles(), getUserRealmRoles()) and also added a realm check to getClientRoles(). The fix added throwIfCannotReadUserInRealm() and throwIfCannotAdminRealm() guards. However, disconnectUserSession was not patched and remains unprotected. Every other mutating method in this class has either a @RolesAllowed annotation on the interface or an explicit realm check in the implementation. This one has neither.

Proof of Concept

Given two realms, "master" and "building":

  1. User A authenticates in the "building" realm (any role, no admin needed).
  2. User B has an active MQTT session in the "master" realm with session ID S.
  3. User A sends: GET /api/master/user/master/disconnect/S with their building-realm bearer token.
  4. The handler ignores the realm path segments, looks up session S in the global connectionIDConnectionMap, and calls doForceDisconnect(). User B's MQTT connection is terminated.

Session IDs use the Netty ChannelId.asLongText() format (deterministic, partially sequential). While not trivially brute-forceable, IDs can leak through monitoring, logs, or correlated API calls. Within the same realm, any user (not just admins) can also disconnect sessions they should not have access to.

Impact

In a multi-tenant IoT deployment, an attacker authenticated in any realm can disrupt MQTT device connectivity in other realms. Since OpenRemote is used for building management, energy monitoring, and industrial IoT, forcibly disconnecting MQTT sessions can:

  • Knock IoT sensors and actuators offline across tenant boundaries
  • Disrupt safety-critical alarm monitoring (compounding the alarm IDOR fixed in CVE-2026-57168)
  • Cause denial of service against other tenants' device fleets

The method also uses HTTP GET for a destructive operation, making it susceptible to CSRF via image tags or link prefetch.

Suggested Fix

Add a realm administration check consistent with the pattern used elsewhere in this file:

@Override
public void disconnectUserSession(RequestParams requestParams, String realm, String sessionID) {
    throwIfCannotAdminRealm(realm);

    RemotingConnection connection = mqttBrokerService.getConnectionByID(sessionID);
    if (connection == null) {
        throw new NotFoundException("User session not found");
    }

    // Verify the session belongs to a user in the requested realm
    // before disconnecting

    if (!mqttBrokerService.disconnectSession(sessionID)) {
        throw new NotFoundException("User session not found");
    }
}

At minimum, add throwIfCannotAdminRealm(realm) as the first line, and consider adding a @RolesAllowed(Constants.WRITE_ADMIN_ROLE) annotation to the interface method. The HTTP method should also be changed from GET to DELETE.

AI tooling

AI assistance was used for the code audit and for drafting this report. The finding against the project's source at the location cited above was manually verified before reporting it, and the severity and impact assessment are the reporter's own.

Database specific
{
    "cwe_ids": [
        "CWE-862"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2026-11-20T14:56:58Z",
    "nvd_published_at": "2026-11-19T20:17:14Z",
    "severity": "MODERATE"
}
References

Affected packages

Maven / io.openremote:openremote-manager

Package

Name
io.openremote:openremote-manager
View open source insights on deps.dev
Purl
pkg:maven/io.openremote/openremote-manager

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0 Unknown introduced version / All previous versions are affected
Fixed
1.31.0

Affected versions

1.*
1.2.0
1.2.1
1.2.2
1.2.3
1.2.4
1.3.0
1.3.1
1.3.2
1.3.3
1.3.4
1.3.5
1.4.0
1.5.0
1.6.0
1.6.2
1.6.3
1.6.4
1.6.5
1.7.0
1.8.0
1.8.1
1.9.0
1.10.0
1.11.0
1.11.1
1.11.2
1.11.3
1.12.0
1.12.1
1.12.3
1.13.0
1.13.1
1.14.0
1.15.0
1.15.1
1.15.2
1.16.1
1.17.0
1.17.1
1.17.2
1.17.3
1.18.0
1.19.0
1.20.0
1.20.1
1.20.2
1.21.0
1.22.0
1.22.1
1.23.0
1.23.1
1.24.0
1.24.1
1.24.2
1.25.0
1.26.0
1.26.1
1.26.2
1.27.0
1.27.1
1.28.1
1.29.0
1.30.0
1.30.1

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-3h6w-xcw3-9xjj/GHSA-3h6w-xcw3-9xjj.json"