GHSA-3v56-q6r6-4gcw

Suggest an improvement
Source
https://github.com/advisories/GHSA-3v56-q6r6-4gcw
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/11/GHSA-3v56-q6r6-4gcw/GHSA-3v56-q6r6-4gcw.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-3v56-q6r6-4gcw
Aliases
Published
2021-11-10T16:41:08Z
Modified
2023-11-08T04:06:53.525740Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N CVSS Calculator
Summary
Insecure Inherited Permissions in neoan3-apps/template
Details

Impact

Versions prior 1.1.1 have allowed for passing in closures directly into the template engine. As a result values that are callable are executed by the template engine. The issue arises if a value has the same name as a method or function in scope and can therefore be executed either by mistake or maliciously.

In theory all users of the package are affected as long as they either deal with direct user input or database values. A multi-step attack on is therefore plausible.

Patches

Version 1.1.1 has addressed this vulnerability.

$params = [
   'reverse' => fn($input) => strrev($input),    // <-- no longer possible with version ~1.1.1
   'value' => 'My website' 
]
TemplateFunctions::registerClosure('reverse', fn($input) => strrev($input));  // <-- still possible (and nicely isolated)
Template::embrace('<h1>{{reverse(value)}}</h1>', $params);

Workarounds

Unfortunately only working with hardcoded values is safe in prior versions. As this likely defeats the purpose of a template engine, please upgrade.

References

As a possible exploit is relatively easy to achieve, I will not share steps to reproduce the issue for now.

For more information

If you have any questions or comments about this advisory: * Open an issue in our repo

Database specific
{
    "nvd_published_at": "2021-11-08T19:15:00Z",
    "github_reviewed_at": "2021-11-08T21:04:44Z",
    "severity": "HIGH",
    "github_reviewed": true,
    "cwe_ids": [
        "CWE-277",
        "CWE-732",
        "CWE-74"
    ]
}
References

Affected packages

Packagist / neoan3-apps/template

Package

Name
neoan3-apps/template
Purl
pkg:composer/neoan3-apps/template

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.1.1

Affected versions

1.*

1.0.0
1.0.1
1.0.2
1.0.3
1.0.4
1.0.5
1.1.0