GHSA-68vr-8f46-vc9f

Suggest an improvement
Source
https://github.com/advisories/GHSA-68vr-8f46-vc9f
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/01/GHSA-68vr-8f46-vc9f/GHSA-68vr-8f46-vc9f.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-68vr-8f46-vc9f
Aliases
Published
2022-01-21T23:20:14Z
Modified
2024-10-08T12:47:50.319409Z
Severity
  • 4.3 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:N CVSS Calculator
  • 5.3 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:L/VI:N/VA:N/SC:N/SI:N/SA:N CVSS Calculator
Summary
Username spoofing in OnionShare
Details

Between September 26, 2021 and October 8, 2021, Radically Open Security conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's Red Team lab. This is an issue from that penetration test.

  • Vulnerability ID: OTF-005
  • Vulnerability type: Improper Input Sanitization
  • Threat level: Low

Description:

It is possible to change the username to that of another chat participant with an additional space character at the end of the name string.

Technical description:

Assumed users in Chat:

  • Alice
  • Bob
  • Mallory
  1. Mallory renames to Alice.
  2. Mallory sends message as Alice.
  3. Alice and Bob receive a message from Mallory disguised as Alice, which is hard to distinguish from the Alice in the web interface.

otf-005-a otf-005-b

Other (invisible) whitespace characters were found to be working as well.

Impact:

An adversary with access to the chat environment can use the rename feature to impersonate other participants by adding whitespace characters at the end of the username.

Recommendation:

  • Remove non-visible characters from the username
Database specific
{
    "nvd_published_at": "2022-01-18T20:15:00Z",
    "cwe_ids": [
        "CWE-20"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2022-01-19T19:41:55Z"
}
References

Affected packages

PyPI / onionshare-cli

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.3
Fixed
2.5

Affected versions

2.*

2.3
2.3.1
2.3.2
2.3.3