GHSA-7h5p-mmpp-hgmm

Summary

A vulnerability has been identified in Nuclei's template signature verification system that could allow an attacker to bypass the signature check and possibly execute malicious code via custom code template.

Affected Component

The vulnerability is present in the template signature verification process, specifically in the signer package.

Description

The vulnerability stems from a discrepancy between how the signature verification process and the YAML parser handle newline characters, combined with the way multiple signatures are processed. This allows an attacker to inject malicious content into a template while maintaining a valid signature for the benign part of the template.

Affected Users

1. CLI Users: Those executing custom code templates from unverified sources. This includes templates authored by third parties or obtained from unverified repositories.
2. SDK Users: Developers integrating Nuclei into their platforms, particularly if they permit the execution of custom code templates by end-users.

[!NOTE] Code templates are disabled as default, users have to explicitly enable with -code option.

Proof of Concept

id: example-template
info:
  name: Example Template
# Other benign content...
# digest: <valid_signature_for_benign_content>
# digest: <another_signature>\r
code:\r
  - engine:\r
      - sh\r
      - bash\r
    source: |\r
      id\r

Patches

1. The vulnerability is addressed in Nuclei v3.3.2 Users are strongly recommended to update to this version to mitigate the security risk.
2. Fix reference - https://github.com/projectdiscovery/nuclei/commit/0da993afe6d41b4b1b814e8fad23a2acba13c60a

Mitigation

• Immediate Upgrade: The primary recommendation is to upgrade to Nuclei v3.2.0, where the vulnerability has been patched.
• Avoid Unverified Templates: As an interim measure, users should refrain from using custom templates if unable to upgrade immediately. Only trusted, verified templates should be executed.

Workarounds

If you are unable to upgrade nuclei, disable running custom code templates as workaround.

Acknowledgments

We would like to thank Guy Goldenberg from Wiz who reported this to us via our security email, security@projectdiscovery.io.