GHSA-7j52-6fjp-58gr

Suggest an improvement
Source
https://github.com/advisories/GHSA-7j52-6fjp-58gr
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/03/GHSA-7j52-6fjp-58gr/GHSA-7j52-6fjp-58gr.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-7j52-6fjp-58gr
Published
2022-03-14T23:22:27Z
Modified
2022-03-14T23:22:27Z
Summary
Inconsistent storage layout for ERC2771ContextUpgradeable
Details

Impact

The storage layout of the ERC2771ContextUpgradeable is not constant between versions.

  • versions 4.0.0, 4.1.0 and 4.2.0, the contract has a length of 51 slots.
  • since 4.3.0, the contract has a length of 50 slots
  • future versions will continue using 50 slots.

This difference in layout could result in breaking upgrades if someone upgrades from an affected version to a non-affected version. It is thus recommended to be extremely careful when upgrading from a contract that uses ERC2771ContextUpgradeable <4.3.0 to a newer version that uses >=4.3.0.

We've assessed the instances of this contract found on chain (with publicly verified source code) and notified the corresponding teams of the risk that an upgrade could cause.

Workarounds

Potentially breaking upgrades would be caught by the OpenZeppelin Upgrades Plugins for Hardhat and Truffle. It is recommended to use this tooling for all your upgrades.

If you need to upgrade to a newer version of the Upgradeable Contracts library, we recommend copying the previous implementation ERC2771ContextUpgradeable (available in the release-4.2 branch) and packaging it with your code.

Reference

https://github.com/OpenZeppelin/openzeppelin-transpiler/pull/86

For more information

If you have any questions, comments, or need assistance regarding this advisory, email us at security@openzeppelin.com.

To submit security reports please use our bug bounty on Immunefi.

Database specific
{
    "cwe_ids": [],
    "github_reviewed": true,
    "github_reviewed_at": "2022-03-14T23:22:27Z",
    "nvd_published_at": null,
    "severity": "LOW"
}
References

Affected packages

npm / @openzeppelin/contracts-upgradeable

Package

Name
@openzeppelin/contracts-upgradeable
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts-upgradeable

Affected ranges

Type
SEMVER
Events
Introduced
4.0.0
Fixed
4.3.0

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/03/GHSA-7j52-6fjp-58gr/GHSA-7j52-6fjp-58gr.json"