GHSA-86xf-2mgp-gv3g

Suggest an improvement
Source
https://github.com/advisories/GHSA-86xf-2mgp-gv3g
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2025/06/GHSA-86xf-2mgp-gv3g/GHSA-86xf-2mgp-gv3g.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-86xf-2mgp-gv3g
Aliases
Published
2025-06-13T14:07:53Z
Modified
2025-06-13T14:42:12Z
Severity
  • 6.5 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:H/I:H/A:N CVSS Calculator
Summary
starcitizentools/citizen-skin allows stored XSS in search no result messages
Details

Summary

The citizen-search-noresults-title and citizen-search-noresults-desc system messages are inserted into raw HTML, allowing anybody who can edit those messages to insert arbitrary HTML into the DOM.

Details

The system messages are inserted as raw HTML by the mustache template: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/407052e7069bdeae927d6f1a2a1c9a45b473bf9a/resources/skins.citizen.search/templates/TypeaheadPlaceholder.mustache#L8-L9

PoC

  1. Edit citizen-search-noresults-title and citizen-search-noresults-desc to <img src="" onerror="alert('citizen-search-noresults-title')"> and <img src="" onerror="alert('citizen-search-noresults-desc')"> (script tags don't work here due to the way the HTML is inserted)
  2. Open the search bar and search for a page that doesn't exist to get the "no results" messages to show up

image image

Impact

This impacts wikis where a group has the editinterface but not the editsitejs user right.

Database specific
{
    "cwe_ids":  [
        "CWE-79"
    ],
    "github_reviewed":  true,
    "github_reviewed_at":  "2025-06-13T14:07:53Z",
    "nvd_published_at":  "2025-06-12T19:15:20Z",
    "severity":  "MODERATE"
}
References

Affected packages

Packagist / starcitizentools/citizen-skin

Package

Name
starcitizentools/citizen-skin
Purl
pkg:composer/starcitizentools/citizen-skin

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.31.0
Fixed
3.3.1

Affected versions

v2.*
v2.31.0
v2.32.0
v2.33.0
v2.34.0
v2.35.0
v2.36.0
v2.37.0
v2.38.0
v2.38.1
v2.38.2
v2.38.3
v2.39.0
v2.39.1
v2.39.2
v2.39.3
v2.39.4
v2.40.0
v2.40.1
v2.40.2
v3.*
v3.0.0
v3.1.0
v3.2.0
v3.3.0

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2025/06/GHSA-86xf-2mgp-gv3g/GHSA-86xf-2mgp-gv3g.json"