GHSA-8jhw-289h-jh2g

Source
https://github.com/advisories/GHSA-8jhw-289h-jh2g
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-8jhw-289h-jh2g/GHSA-8jhw-289h-jh2g.json
Aliases
Published
2024-04-03T16:46:17Z
Modified
2024-04-05T01:28:39.527659Z
Details

Summary

Vite dev server option server.fs.deny did not deny requests for patterns with directories. An example of such a pattern is /foo/**/*.

Impact

Only apps setting a custom server.fs.deny that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Patches

Fixed in vite@5.2.6, vite@5.1.7, vite@5.0.13, vite@4.5.3, vite@3.2.10, vite@2.9.18

Details

server.fs.deny uses picomatch with the config of { matchBase: true }. matchBase only matches the basename of the file, not the path due to a bug (https://github.com/micromatch/picomatch/issues/89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set { dot: true } and that causes dotfiles not to be denied unless they are explicitly defined.

Reproduction

Set fs.deny to ['**/.git/**'] and then curl for /.git/config.

  • with matchBase: true, you can get any file under .git/ (config, HEAD, etc).
  • with matchBase: false, you cannot get any file under .git/ (config, HEAD, etc).
References

Affected packages

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
2.7.0
Fixed
2.9.18

Database specific

{
    "last_known_affected_version_range": "<= 2.9.17"
}

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
3.0.0
Fixed
3.2.10

Database specific

{
    "last_known_affected_version_range": "<= 3.2.8"
}

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
4.0.0
Fixed
4.5.3

Database specific

{
    "last_known_affected_version_range": "<= 4.5.2"
}

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
5.0.0
Fixed
5.0.13

Database specific

{
    "last_known_affected_version_range": "<= 5.0.12"
}

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
5.1.0
Fixed
5.1.7

Database specific

{
    "last_known_affected_version_range": "<= 5.1.6"
}

npm / vite

Package

Name
vite

Affected ranges

Type
SEMVER
Events
Introduced
5.2.0
Fixed
5.2.6

Database specific

{
    "last_known_affected_version_range": "<= 5.2.5"
}