GHSA-8pgv-569h-w5rw

Source

https://github.com/advisories/GHSA-8pgv-569h-w5rw

Import Source

https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/11/GHSA-8pgv-569h-w5rw/GHSA-8pgv-569h-w5rw.json

JSON Data

https://api.osv.dev/v1/vulns/GHSA-8pgv-569h-w5rw

Aliases

Related

Published

2023-11-12T15:55:39Z

Modified

2024-10-22T05:28:53.341824Z

Severity

7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator

Summary

otelgrpc DoS vulnerability due to unbound cardinality metrics

Details

Summary

The grpc Unary Server Interceptor opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go

// UnaryServerInterceptor returns a grpc.UnaryServerInterceptor suitable
// for use in a grpc.NewServer call.
func UnaryServerInterceptor(opts ...Option) grpc.UnaryServerInterceptor {

out of the box adds labels

net.peer.sock.addr
net.peer.sock.port

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent.

Details

An attacker can easily flood the peer address and port for requests.

PoC

Apply the attached patch to the example and run the client multiple times. Observe how each request will create a unique histogram and how the memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use UnaryServerInterceptor, and does not filter any client IP address and ports via middleware or proxies, etc.

Others

It is similar to already reported vulnerabilities.

Workaround for affected versions

As a workaround to stop being affected, a view removing the attributes can be used.

The other possibility is to disable grpc metrics instrumentation by passing otelgrpc.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR #4322, to be released with v0.46.0, the attributes were removed.

References

#4322

Database specific

{
    "nvd_published_at": "2023-11-10T19:15:16Z",
    "cwe_ids": [
        "CWE-770"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2023-11-12T15:55:39Z"
}

References

Affected packages

Go / go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

Package

Name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc; View open source insights on deps.dev
Purl: pkg:golang/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

Affected ranges

Type: SEMVER
Events: Introduced

0Unknown introduced version / All previous versions are affected

Fixed

0.46.0