GHSA-93hq-5wgc-jc82

Suggest an improvement
Source
https://github.com/advisories/GHSA-93hq-5wgc-jc82
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/04/GHSA-93hq-5wgc-jc82/GHSA-93hq-5wgc-jc82.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-93hq-5wgc-jc82
Aliases
Related
Published
2023-04-20T14:11:03Z
Modified
2023-11-08T04:12:24.945774Z
Severity
  • 8.8 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H CVSS Calculator
Summary
GovernorCompatibilityBravo may trim proposal calldata
Details

Impact

The proposal creation entrypoint (propose) in GovernorCompatibilityBravo allows the creation of proposals with a signatures array shorter than the calldatas array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The ProposalCreated event correctly represents what will eventually execute, but the proposal parameters as queried through getActions appear to respect the original intended calldata.

Patches

This issue has been patched in v4.8.3.

Workarounds

Ensure that all proposals that pass through governance have equal length signatures and calldatas parameters.

Database specific
{
    "github_reviewed_at": "2023-04-20T14:11:03Z",
    "cwe_ids": [
        "CWE-20"
    ],
    "severity": "HIGH",
    "nvd_published_at": "2023-04-16T08:15:00Z",
    "github_reviewed": true
}
References

Affected packages

npm / @openzeppelin/contracts

Package

Name
@openzeppelin/contracts
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts

Affected ranges

Type
SEMVER
Events
Introduced
4.3.0
Fixed
4.8.3

npm / @openzeppelin/contracts-upgradeable

Package

Name
@openzeppelin/contracts-upgradeable
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts-upgradeable

Affected ranges

Type
SEMVER
Events
Introduced
4.3.0
Fixed
4.8.3