GHSA-99p8-9p2c-49j4
Suggest an improvement- Source
- https://github.com/advisories/GHSA-99p8-9p2c-49j4
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/01/GHSA-99p8-9p2c-49j4/GHSA-99p8-9p2c-49j4.json
- JSON Data
- https://api.osv.dev/v1/vulns/GHSA-99p8-9p2c-49j4
- Aliases
- Related
- Published
- 2022-01-21T23:20:16Z
- Modified
- 2024-10-08T12:47:29.376558Z
- Severity
-
- 4.3 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:N/A:N CVSS Calculator
- 5.1 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:A/VC:L/VI:N/VA:N/SC:N/SI:N/SA:N CVSS Calculator
- Summary
- Improper Access Control in Onionshare
- Details
-
Between September 26, 2021 and October 8, 2021, Radically Open Security conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's Red Team lab. This is an issue from that penetration test.
- Vulnerability ID: OTF-009
- Vulnerability type: Improper Access Control
- Threat level: Low
Description:
Authenticated users (or unauthenticated in public mode) can send messages without being visible in the list of chat participants.
Technical description:
Prerequisites:
- Existing chatroom
- Access to the chatroom (Public or known Private Key)
- Either a modified frontend client or manual requests from burp/curl
If a user opens the chatroom without emitting the join message he will not be present in session.users[x] list. Therefore there is no listing in the frontend and no chat participant knows another party joined the chat. It is still possible to send messages in the chatroom.
If a user decides to abuse OTF-003 (page 22) he can impersonate messages from existing users; others would not be able to distinguish original and faked messages. This is also a prerequisite for OTF-004 (page 19).
Impact:
An adversary with access to the chat environment can send messages to the chat without being visible in the list of chat participants.
Recommendation:
- Allow chat access only after emission of the join event.
- Implement proper session handling.
- Database specific
{ "nvd_published_at": "2022-01-18T22:15:00Z", "cwe_ids": [ "CWE-287" ], "severity": "MODERATE", "github_reviewed": true, "github_reviewed_at": "2022-01-19T19:40:50Z" }- References
-
- https://github.com/onionshare/onionshare/security/advisories/GHSA-99p8-9p2c-49j4
- https://nvd.nist.gov/vuln/detail/CVE-2022-21695
- https://github.com/onionshare/onionshare
- https://github.com/onionshare/onionshare/releases/tag/v2.5
- https://github.com/pypa/advisory-database/tree/main/vulns/onionshare-cli/PYSEC-2022-46.yaml
Affected packages
PyPI / onionshare-cli
Package
- Name
- onionshare-cli
- View open source insights on deps.dev
- Purl
- pkg:pypi/onionshare-cli