GHSA-9c22-pwxw-p6hx

Suggest an improvement
Source
https://github.com/advisories/GHSA-9c22-pwxw-p6hx
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/12/GHSA-9c22-pwxw-p6hx/GHSA-9c22-pwxw-p6hx.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-9c22-pwxw-p6hx
Aliases
Related
Published
2021-12-14T21:47:33Z
Modified
2025-01-14T10:12:20.723148Z
Severity
  • 5.6 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:L/A:L CVSS Calculator
Summary
OpenZeppelin Contracts initializer reentrancy may lead to double initialization
Details

Impact

Initializer functions that are invoked separate from contract creation (the most prominent example being minimal proxies) may be reentered if they make an untrusted non-view external call.

Once an initializer has finished running it can never be re-executed. However, an exception put in place to support multiple inheritance made reentrancy possible in the scenario described above, breaking the expectation that there is a single execution.

Note that upgradeable proxies are commonly initialized together with contract creation, where reentrancy is not feasible, so the impact of this issue is believed to be minor.

Patches

A fix is included in the version v4.4.1 of @openzeppelin/contracts and @openzeppelin/contracts-upgradeable.

Workarounds

Avoid untrusted external calls during initialization.

References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3006

Credits

This issue was identified and reported by @chaitinblockchain through our bug bounty on Immunefi.

For more information

If you have any questions or comments about this advisory, or need assistance executing the mitigation, email us at security@openzeppelin.com.

Database specific
{
    "cwe_ids": [
        "CWE-665"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2021-12-14T19:22:45Z",
    "nvd_published_at": "2022-11-04T22:15:00Z",
    "severity": "MODERATE"
}
References

Affected packages

npm / @openzeppelin/contracts

Package

Name
@openzeppelin/contracts
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts

Affected ranges

Type
SEMVER
Events
Introduced
3.2.0
Fixed
4.4.1

npm / @openzeppelin/contracts-upgradeable

Package

Name
@openzeppelin/contracts-upgradeable
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts-upgradeable

Affected ranges

Type
SEMVER
Events
Introduced
3.2.0
Fixed
4.4.1