GHSA-9xfw-jjq2-7v8h

Suggest an improvement
Source
https://github.com/advisories/GHSA-9xfw-jjq2-7v8h
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/02/GHSA-9xfw-jjq2-7v8h/GHSA-9xfw-jjq2-7v8h.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-9xfw-jjq2-7v8h
Aliases
Published
2024-02-05T20:19:30Z
Modified
2024-06-28T15:58:30.453717Z
Severity
  • 6.5 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:L CVSS Calculator
Summary
1Panel set-cookie is missing the Secure keyword
Details

Summary

The https cookie that comes with the panel does not have the Secure keyword, which may cause the cookie to be sent in plain text when accessing http accidentally.

https://developer.mozilla.org/zh-CN/docs/Web/HTTP/Headers/Set-Cookie#secure

PoC

Directly configure https for the panel, and then capture the packet when logging in again and find that the cookie does not have the Secure keyword

Impact

Everyone who has configured the panel https

References

Affected packages

Go / github.com/1Panel-dev/1Panel

Package

Name
github.com/1Panel-dev/1Panel
View open source insights on deps.dev
Purl
pkg:golang/github.com/1Panel-dev/1Panel

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.9.6

Database specific

{
    "last_known_affected_version_range": "<= 1.9.5"
}