GHSA-fcmm-54jp-7vf6
Suggest an improvement- Source
- https://github.com/advisories/GHSA-fcmm-54jp-7vf6
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/03/GHSA-fcmm-54jp-7vf6/GHSA-fcmm-54jp-7vf6.json
- JSON Data
- https://api.osv.dev/v1/vulns/GHSA-fcmm-54jp-7vf6
- Aliases
- Published
- 2023-03-21T22:31:30Z
- Modified
- 2024-10-24T21:21:00Z
- Severity
-
- 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
- Summary
- Frontier's modexp precompile is slow for even modulus
- Details
-
Impact
Frontier's
modexpprecompile usesnum-bigintcrate under the hood. In the implementation, the cases for modulus being even and modulus being odd are treated separately. Odd modulus uses the fast Montgomery multiplication, and even modulus uses the slow plain power algorithm. This gas cost discrepancy was not accounted for in themodexpprecompile, leading to possible denial of service attacks.Patches
No fixes for
num-bigintis currently available, and thus this advisory will be first fixed in the short term by raising the gas costs for even modulus, and in the long term fixing it innum-bigintor switching to another modexp implementation.The short-term fix for Frontier is deployed at PR 1017.
The recommendations are as follows:
- If you anticipate malicious validators, it's recommended to issue an emergency runtime upgrade as soon as possible.
- If you do not anticipate malicious validators, it's recommended to issue a normal runtime upgrade, as Substrate has builtin timeout protection when validators are building blocks.
Workarounds
None.
References
A similar issue was presented in Geth's implementation and the fix can be found here.
- Database specific
{ "nvd_published_at": "2023-03-22T21:15:00Z", "cwe_ids": [ "CWE-682" ], "severity": "HIGH", "github_reviewed": true, "github_reviewed_at": "2023-03-21T22:31:30Z" }- References
-
- https://github.com/paritytech/frontier/security/advisories/GHSA-fcmm-54jp-7vf6
- https://nvd.nist.gov/vuln/detail/CVE-2023-28431
- https://github.com/paritytech/frontier/pull/1017
- https://github.com/paritytech/frontier/commit/5af12e94d7dfc8a0208a290643a800f55de7b219
- https://github.com/polkadot-evm/frontier
- https://github.com/rust-num/num-bigint/blob/6f2b8e0fc218dbd0f49bebb8db2d1a771fe6bafa/src/biguint/power.rs#L134
Affected packages
crates.io / pallet-evm-precompile-modexp
Package
- Name
- pallet-evm-precompile-modexp
- View open source insights on deps.dev
- Purl
- pkg:cargo/pallet-evm-precompile-modexp