GHSA-h24c-6p6p-m3vx

Suggest an improvement
Source
https://github.com/advisories/GHSA-h24c-6p6p-m3vx
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/09/GHSA-h24c-6p6p-m3vx/GHSA-h24c-6p6p-m3vx.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-h24c-6p6p-m3vx
Published
2023-09-01T20:51:05Z
Modified
2023-09-01T20:51:05Z
Summary
tss-lib leaks secret keys in response to incorrectly constructed Paillier moduli
Details

Impact

The specification of the GG18 threshold ECDSA signature protocol contains a vulnerability allowing an attacker to recover the shared secret key. If a participant generates a Paillier modulus N containing small factors (less than 2^100) they can interact with other participants in the signing protocol to steal their secret key shares in as little as sixteen signing attempts. The master key can then be reconstructed from these shares.

Patches

The implementation of GG18 in tss-lib did not prove that N is biprime or that it doesn't contain small factors. The fixed implementation adds the following proofs from the CGGMP21 threshold ECDSA protocol to the key generation:

  • Paillier-Blum Modulus (N is the product of two primes)
  • No Small Factor (both factors of N are greater than 2^256)

These proofs apply to both the Paillier encryption modulus N, and the modulus NTilde used in MTA proofs.

To address the issue in the resharing protocol, an additional round has been added to the end so that participants can confirm that they received valid proofs.

References

Database specific
{
    "cwe_ids":  [
        "CWE-200"
    ],
    "github_reviewed":  true,
    "github_reviewed_at":  "2023-09-01T20:51:05Z",
    "nvd_published_at":  null,
    "severity":  "CRITICAL"
}
References

Affected packages

Go / github.com/bnb-chain/tss-lib

Package

Name
github.com/bnb-chain/tss-lib
View open source insights on deps.dev
Purl
pkg:golang/github.com/bnb-chain/tss-lib

Affected ranges

Type
SEMVER
Events
Introduced
0 Unknown introduced version / All previous versions are affected
Last Affected
1.3.5

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/09/GHSA-h24c-6p6p-m3vx/GHSA-h24c-6p6p-m3vx.json"