GHSA-hc2f-7r5r-r2hg

Suggest an improvement
Source
https://github.com/advisories/GHSA-hc2f-7r5r-r2hg
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/05/GHSA-hc2f-7r5r-r2hg/GHSA-hc2f-7r5r-r2hg.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-hc2f-7r5r-r2hg
Aliases
Published
2022-05-24T22:15:20Z
Modified
2024-02-16T08:09:36.089570Z
Severity
  • 5.5 (Medium) CVSS_V3 - CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
Summary
Heap buffer overflow due to incorrect hash function in TensorFlow
Details

Impact

The TensorKey hash function used total estimated AllocatedBytes(), which (a) is an estimate per tensor, and (b) is a very poor hash function for constants (e.g. int32_t). It also tried to access individual tensor bytes through tensor.data() of size AllocatedBytes(). This led to ASAN failures because the AllocatedBytes() is an estimate of total bytes allocated by a tensor, including any pointed-to constructs (e.g. strings), and does not refer to contiguous bytes in the .data() buffer. We couldn't use this byte vector anyways, since types like tstring include pointers, whereas we need to hash the string values themselves.

Patches

We have patched the issue in GitHub commit 1b85a28d395dc91f4d22b5f9e1e9a22e92ccecd6.

The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, which is the only other affected version.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

References

Affected packages

PyPI / tensorflow

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.8.0
Fixed
2.8.1

Affected versions

2.*

2.8.0

PyPI / tensorflow-cpu

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.8.0
Fixed
2.8.1

Affected versions

2.*

2.8.0

PyPI / tensorflow-gpu

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.8.0
Fixed
2.8.1

Affected versions

2.*

2.8.0