GHSA-p4cc-w597-6cpm

Suggest an improvement
Source
https://github.com/advisories/GHSA-p4cc-w597-6cpm
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/08/GHSA-p4cc-w597-6cpm/GHSA-p4cc-w597-6cpm.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-p4cc-w597-6cpm
Aliases
Related
Published
2022-08-30T20:38:10Z
Modified
2023-11-08T04:09:58.724209Z
Severity
  • 9.8 (Critical) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H CVSS Calculator
Summary
Cryptographically weak PRNG in `utils.generateUUID`
Details

In Brief

utils.generateUUID, a helper function available in essentially all versions of NodeBB (as far back as v1.0.1 and potentially earlier) used a cryptographically insecure Pseudo-random number generator (Math.random()), which meant that a specially crafted script combined with multiple invocations of the password reset functionality could enable an attacker to correctly calculate the reset code for an account they do not have access to.

Impact

This vulnerability impacts all installations of NodeBB. The vulnerability allows for an attacker to take over any account without the involvement of the victim, and as such, the remediation should be applied immediately (either via NodeBB upgrade or cherry-pick of the specific changeset. Patches have been provided for both active branches of NodeBB (v2.x and v1.19.x)—please see below.

If you are already on v2.0.0 or v1.19.7, you can upgrade with no ill effects. The new version contains only the patch for this vulnerability.

The impact of this vulnerability is slightly lessened by the requirement that the target's email address must be known, and user emails are protected values in NodeBB. However, since NodeBB can be configured to display email addresses if the admin so wishes, and as email addresses can often by derived from other sources and/or guessed, the impact of this vulnerability is still fairly high.

Patches

v2.x

The vulnerability has been patched in https://github.com/NodeBB/NodeBB/commit/e802fab87f94a13f397f04cfe6068f2f7ddf7888. You can cherry-pick this directly into your codebase.

v1.19.x

The vulnerability has been patched in 81e3c1ba488d03371a5ce8d0ebb5c5803026e0f9. You can cherry-pick this directly into your codebase.

Workarounds

There is no known workaround, but the patch sets listed above will fully patch the vulnerability.

References

For more information

If you have any questions or comments about this advisory: * Discuss it on our community forum * Email us at support@nodebb.org

Database specific 
{
    "github_reviewed": true,
    "github_reviewed_at": "2022-08-30T20:38:10Z",
    "cwe_ids": [
        "CWE-330",
        "CWE-338"
    ],
    "nvd_published_at": "2022-08-31T15:15:00Z",
    "severity": "CRITICAL"
}
References

Affected packages

npm / nodebb

Package

Name
nodebb
View open source insights on deps.dev
Purl
pkg:npm/nodebb

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.19.8

npm / nodebb

Package

Name
nodebb
View open source insights on deps.dev
Purl
pkg:npm/nodebb

Affected ranges

Type
SEMVER
Events
Introduced
2.0.0
Fixed
2.0.1

Affected versions

2.*

2.0.0