GHSA-p5w8-wqhj-9hhf
Suggest an improvement- Source
- https://github.com/advisories/GHSA-p5w8-wqhj-9hhf
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/09/GHSA-p5w8-wqhj-9hhf/GHSA-p5w8-wqhj-9hhf.json
- JSON Data
- https://api.osv.dev/v1/vulns/GHSA-p5w8-wqhj-9hhf
- Aliases
- Published
- 2021-09-10T17:56:06Z
- Modified
- 2024-10-28T14:45:13.603826Z
- Severity
-
- 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
- 8.7 (High) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N CVSS Calculator
- Summary
- StripComments filter contains a regular expression that is vulnerable to ReDOS (Regular Expression Denial of Service)
- Details
-
Impact
The formatter function that strips comments from a SQL contains a regular expression that is vulnerable to ReDoS (Regular Expression Denial of Service). The regular expression may cause exponential backtracking on strings containing many repetitions of '\r\n' in SQL comments.
Patches
The issues has been fixed in sqlparse 0.4.2.
Workarounds
Only the formatting feature that removes comments from SQL statements is affected by this regular expression. As a workaround don't use the
sqlformat.formatfunction with keywordstrip_comments=Trueor the--strip-commentscommand line flag when using thesqlformatcommand line tool.References
This issue was discovered by GitHub team members @erik-krogh and @yoff. It was found using a CodeQL query which identifies inefficient regular expressions. You can see the results of the query on python-sqlparse by following this link.
For more information
If you have any questions or comments about this advisory: * Open an issue in sqlparse issue tracker * Email us at albrecht.andi@gmail.com
- Database specific
{ "nvd_published_at": "2021-09-20T17:15:00Z", "cwe_ids": [ "CWE-400" ], "severity": "HIGH", "github_reviewed": true, "github_reviewed_at": "2021-09-10T17:13:29Z" }- References
-
- https://github.com/andialbrecht/sqlparse/security/advisories/GHSA-p5w8-wqhj-9hhf
- https://nvd.nist.gov/vuln/detail/CVE-2021-32839
- https://github.com/andialbrecht/sqlparse/commit/8238a9e450ed1524e40cb3a8b0b3c00606903aeb
- https://github.com/andialbrecht/sqlparse
- https://github.com/pypa/advisory-database/tree/main/vulns/sqlparse/PYSEC-2021-333.yaml
- https://securitylab.github.com/advisories/GHSL-2021-107-andialbrecht-sqlparse
Affected packages
PyPI / sqlparse
Package
- Name
- sqlparse
- View open source insights on deps.dev
- Purl
- pkg:pypi/sqlparse