GHSA-pqr6-cmr2-h8hf

Suggest an improvement
Source
https://github.com/advisories/GHSA-pqr6-cmr2-h8hf
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/06/GHSA-pqr6-cmr2-h8hf/GHSA-pqr6-cmr2-h8hf.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-pqr6-cmr2-h8hf
Aliases
Related
Published
2023-06-15T16:13:20Z
Modified
2024-02-16T08:00:57.023897Z
Severity
  • 5.9 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
Summary
snappy-java's Integer Overflow vulnerability in shuffle leads to DoS
Details

Summary

Due to unchecked multiplications, an integer overflow may occur, causing a fatal error.

Impact

Denial of Service

Description

The function shuffle(int[] input) in the file BitShuffle.java receives an array of integers and applies a bit shuffle on it. It does so by multiplying the length by 4 and passing it to the natively compiled shuffle function.

public static byte[] shuffle(int[] input) throws IOException {
        byte[] output = new byte[input.length * 4];
        int numProcessed = impl.shuffle(input, 0, 4, input.length * 4, output, 0);
        assert(numProcessed == input.length * 4);
        return output;
    }

Since the length is not tested, the multiplication by four can cause an integer overflow and become a smaller value than the true size, or even zero or negative. In the case of a negative value, a “java.lang.NegativeArraySizeException” exception will raise, which can crash the program. In a case of a value that is zero or too small, the code that afterwards references the shuffled array will assume a bigger size of the array, which might cause exceptions such as “java.lang.ArrayIndexOutOfBoundsException”. The same issue exists also when using the “shuffle” functions that receive a double, float, long and short, each using a different multiplier that may cause the same issue.

Steps To Reproduce

Compile and run the following code:

package org.example;
import org.xerial.snappy.BitShuffle;

import java.io.*;


public class Main {

    public static void main(String[] args) throws IOException {
        int[] original = new int[0x40000000];
        byte[] shuffled = BitShuffle.shuffle(original);
        System.out.println(shuffled[0]);
    }
}

The program will crash, showing the following error (or similar):

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
    at org.example.Main.main(Main.java:12)

Process finished with exit code 1

Alternatively - compile and run the following code:

package org.example;
import org.xerial.snappy.BitShuffle;

import java.io.*;


public class Main {

    public static void main(String[] args) throws IOException {
        int[] original = new int[0x20000000];
        byte[] shuffled = BitShuffle.shuffle(original);
    }
}

The program will crash with the following error (or similar):

Exception in thread "main" java.lang.NegativeArraySizeException: -2147483648
    at org.xerial.snappy.BitShuffle.shuffle(BitShuffle.java:108)
    at org.example.Main.main(Main.java:11)
Database specific
{
    "nvd_published_at": "2023-06-15T17:15:09Z",
    "cwe_ids": [
        "CWE-190"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2023-06-15T16:13:20Z"
}
References

Affected packages

Maven / org.xerial.snappy:snappy-java

Package

Name
org.xerial.snappy:snappy-java
View open source insights on deps.dev
Purl
pkg:maven/org.xerial.snappy/snappy-java

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.1.10.1

Affected versions

1.*

1.0.1-rc1
1.0.1-rc2
1.0.1-rc3
1.0.1-rc4
1.0.3-rc1
1.0.3-rc2
1.0.3-rc3
1.0.3-rc4
1.0.3
1.0.3.1
1.0.3.2
1.0.3.3
1.0.4
1.0.4.1
1.0.5-M1
1.0.5-M2
1.0.5-M3
1.0.5-M4
1.0.5
1.0.5.1
1.0.5.2
1.0.5.3
1.0.5.4
1.1.0-M1
1.1.0-M2
1.1.0-M3
1.1.0-M4
1.1.0
1.1.0.1
1.1.1-M1
1.1.1-M2
1.1.1-M3
1.1.1-M4
1.1.1
1.1.1.1
1.1.1.2
1.1.1.3
1.1.1.4
1.1.1.5
1.1.1.6
1.1.1.7
1.1.2-M1
1.1.2-RC1
1.1.2-RC2
1.1.2-RC3
1.1.2
1.1.2.1
1.1.2.2
1.1.2.3
1.1.2.4
1.1.2.5
1.1.2.6
1.1.3-M1
1.1.3-M2
1.1.4-M1
1.1.4-M2
1.1.4-M3
1.1.4
1.1.7
1.1.7.1
1.1.7.2
1.1.7.3
1.1.7.4
1.1.7.5
1.1.7.6
1.1.7.7
1.1.7.8
1.1.8
1.1.8.1
1.1.8.2
1.1.8.3
1.1.8.4
1.1.9.0
1.1.9.1
1.1.10.0

Database specific

{
    "last_known_affected_version_range": "<= 1.1.10.0"
}