GHSA-qmmm-73r2-f8xr

Suggest an improvement
Source
https://github.com/advisories/GHSA-qmmm-73r2-f8xr
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-qmmm-73r2-f8xr/GHSA-qmmm-73r2-f8xr.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-qmmm-73r2-f8xr
Aliases
Published
2024-04-22T18:38:11Z
Modified
2024-05-08T17:50:07Z
Severity
  • 8.3 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:C/C:H/I:H/A:H CVSS Calculator
Summary
@hoppscotch/cli affected by Sandbox Escape in @hoppscotch/js-sandbox leads to RCE
Details

Observations

The Hoppscotch desktop app takes multiple precautions to be secure against arbitrary JavaScript and system command execution. It does not render user-controlled HTML or Markdown, uses Tauri instead of Electron, and sandboxes pre-request scripts with a simple yet secure implementation using web workers.

Unfortunately, web workers are not available in a pure Node.js application like Hoppscotch CLI. That is why the @hoppscotch/js-sandbox package also provides a Javascript sandbox that uses the Node.js vm module. However, the vm module is not safe for sandboxing untrusted Javascript code, as stated in the documentation. This is because code inside the vm context can break out if it can get a hold of any reference to an object created outside of the vm.

In the case of @hoppscotch/js-sandbox, multiple references to external objects are passed into the vm context to allow pre-request scripts interactions with environment variables and more. But this also allows the pre-request script to escape the sandbox. packages/hoppscotch-js-sandbox/src/pre-request/node-vm/index.ts

const { pw, updatedEnvs } = getPreRequestScriptMethods(envs)

// Expose pw to the context
context.pw = pw
context.atob = atob
context.btoa = btoa

// Run the pre-request script in the provided context
runInContext(preRequestScript, context)

Exploitation

An attacker can use the exposed pw object reference to escape the sandbox and execute arbitrary system commands using the child_process Node.js module. This PoC pre-request script executes the id > /tmp/pwnd system command as soon as a request is sent.

outside = pw.constructor.constructor('return this')()
outside.process.mainModule.require('child_process').execSync('id > /tmp/pwnd')

An attacker who wants to run arbitrary code on the machine of a victim can create a Hoppscotch collection containing a request with a malicious pre-request script and share it with a victim, using the JSON export feature. The victim then has to run the collection with the Hoppscotch CLI. Then the malicious pre-request script executes.

Impact

This attack gives an attacker arbitrary command execution on the machine of a victim Hoppscotch CLI user. For the attack to succeed, an attacker has to lure the victim into downloading a malicious Hoppscotch collection and running it with the Hoppscotch CLI.

This issue does not impact Hoppscotch Web or Desktop, as they use the safe web worker sandboxing approach.

Recommendations

Hoppscotch CLI and other tools that rely on @hoppscotch/js-sandbox but don't have access to a browser cannot use the web worker sandbox. For these, you can look into other safe JavaScript sandboxing libraries. We think that isolated-vm looks promising. We discourage the use of vm2, which is deprecated because it has arbitrary bypasses. Alternatively, you can introduce an --enable-scripting flag for the CLI and disable scripting by default. Or you can change the threat model and educate users that they should not run untrusted collections as it can lead to RCE.

Differences from existing CVEs

References

Affected packages

npm / @hoppscotch/cli

Package

Name
@hoppscotch/cli
View open source insights on deps.dev
Purl
pkg:npm/%40hoppscotch/cli

Affected ranges

Type
SEMVER
Events
Introduced
0.5.0
Fixed
0.8.0