GHSA-qmv4-jgp7-mf68

Suggest an improvement
Source
https://github.com/advisories/GHSA-qmv4-jgp7-mf68
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2019/02/GHSA-qmv4-jgp7-mf68/GHSA-qmv4-jgp7-mf68.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-qmv4-jgp7-mf68
Aliases
Published
2019-02-18T23:40:10Z
Modified
2023-11-08T03:58:11.949348Z
Summary
Sails before 0.12.7 vulnerable to Broken CORS
Details

Affected versions of sails have an issue with the CORS configuration where the value of the origin header is reflected as the value for the Access-Control-Allow-Origin header. This may allow an attacker to make AJAX requests to vulnerable hosts through cross-site scripting or a malicious HTML Document, effectively bypassing the Same Origin Policy.

Mitigating Factors

This is only an issue when allRoutes is set to true and origin is set to * or left commented out in the sails CORS config file.

The problem can be compounded when the cors credentials setting is not provided, because at that point authenticated cross domain requests are possible.

Recommendation

Update to version 0.12.7 or later.

As this vulnerability is primarily a user error, the patch for the vulnerability will simply cause the application to write an error message to the console when a vulnerable configuration is used in a production environment.

Writing a proper CORS configuration is still the responsibility of the user, so it is necessary to check for the error message after installing the patch. Be sure you are not using allRoutes: true with origin:'*', and that you uncomment origin and set it to a reasonable value. Ensure that if origin is set to * that you truly mean for all other websites to be able to make cross-domain requests to your API.

Likewise, ensure credentials is uncommented out and set to the appropriate value. Make sure to explicitly set which origins may request resources via CORS.

Database specific 
{
    "github_reviewed": true,
    "severity": "HIGH",
    "nvd_published_at": null,
    "cwe_ids": [
        "CWE-284"
    ],
    "github_reviewed_at": "2020-06-16T21:52:24Z"
}
References

Affected packages

npm / sails

Package

Name
sails
View open source insights on deps.dev
Purl
pkg:npm/sails

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
0.12.7

Database specific

source 
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2019/02/GHSA-qmv4-jgp7-mf68/GHSA-qmv4-jgp7-mf68.json"