GHSA-v666-6w97-pcwm

Suggest an improvement
Source
https://github.com/advisories/GHSA-v666-6w97-pcwm
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/08/GHSA-v666-6w97-pcwm/GHSA-v666-6w97-pcwm.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-v666-6w97-pcwm
Aliases
Published
2021-08-25T21:01:21Z
Modified
2023-11-08T04:07:22.565827Z
Summary
Miner fails to get block template when a cell used as a cell dep has been destroyed.
Details

Impact

The RPC get_block_template fails when a cell has been used as a cell dep and an input in the different transactions.

Say cell C is used as a dep group in the transaction A, and is destroyed in the transaction B.

The node adds transaction A first, then B into the transaction pool. They are both valid. But when generating the block template, if the fee rate of B is higher, it comes before A, which will invalidate A. Currently the RPC get_block_template will fail instead of dropping A.

Patch

First, the get_block_template should not fail but dropping the conflict transactions.

Then we can propose solution to this issue. Here is an example. When a transaction is added to the pool, the pool must consider it depending on all the transactions which dep cell (direct or indirect via dep group) has been destroyed in this transaction. Because future transactions using the destroyed cells as dep will be rejected, the spending transaction only need to wait for all the existing dep transactions on chain.

Workaround

  1. Submit transaction B when A is already on chain.
  2. Let B depend on A explicitly, there are several solutions:
    • a. Add any output cell on A as a dep cell or input in B.
    • b. Merge A and B. CKB allows using the same cell as both dep and input in the same transaction.
  3. Ensure the fee rate of B is less than A so A always has higher priority.
Database specific 
{
    "nvd_published_at": null,
    "cwe_ids": [
        "CWE-367"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2021-08-02T21:55:20Z"
}
References

Affected packages

crates.io / ckb

Package

Name
ckb
View open source insights on deps.dev
Purl
pkg:cargo/ckb

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
0.40.0