GHSA-vhr5-g3pm-49fm

Suggest an improvement
Source
https://github.com/advisories/GHSA-vhr5-g3pm-49fm
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/08/GHSA-vhr5-g3pm-49fm/GHSA-vhr5-g3pm-49fm.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-vhr5-g3pm-49fm
Aliases
Published
2024-08-20T18:35:27Z
Modified
2024-08-20T18:58:55.366577Z
Severity
  • 4.1 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:N/I:N/A:L CVSS Calculator
  • 5.1 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:P/VC:N/VI:N/VA:L/SC:N/SI:N/SA:L CVSS Calculator
Summary
matrix-js-sdk will freeze when a user sets a room with itself as a its predecessor
Details

Impact

A malicious homeserver can craft a room or room structure such that the predecessors form a cycle. The matrix-js-sdk's getRoomUpgradeHistory function will infinitely recurse in this case, causing the code to hang. This method is public but also called by the 'leaveRoomChain()' method, so leaving a room will also trigger the bug.

Even if the CVSS score would be 4.1 (AV:N/AC:L/PR:L/UI:R/S:C/C:N/I:N/A:L) we classify this as High severity issue.

Patches

This was patched in matrix-js-sdk 34.3.1.

Workarounds

Sanity check rooms before passing them to the matrix-js-sdk or avoid calling either getRoomUpgradeHistory or leaveRoomChain.

References

N/A.

Database specific
{
    "nvd_published_at": "2024-08-20T15:15:21Z",
    "cwe_ids": [
        "CWE-674"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2024-08-20T18:35:27Z"
}
References

Affected packages

npm / matrix-js-sdk

Package

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
34.3.1