GHSA-vv2x-vrpj-qqpq

Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/02/GHSA-vv2x-vrpj-qqpq/GHSA-vv2x-vrpj-qqpq.json
Aliases
Published
2021-02-02T17:58:40Z
Modified
2022-09-19T02:49:25.646253Z
Details

Impact

A mutation XSS affects users calling bleach.clean with all of:

  • svg or math in the allowed tags
  • p or br in allowed tags
  • style, title, noscript, script, textarea, noframes, iframe, or xmp in allowed tags
  • the keyword argument strip_comments=False

Note: none of the above tags are in the default allowed tags and strip_comments defaults to True.

Patches

Users are encouraged to upgrade to bleach v3.3.0 or greater.

Note: bleach v3.3.0 introduces a breaking change to escape HTML comments by default.

Workarounds

  • modify bleach.clean calls to at least one of:

    • not allow the style, title, noscript, script, textarea, noframes, iframe, or xmp tag
    • not allow svg or math tags
    • not allow p or br tags
    • set strip_comments=True
  • A strong Content-Security-Policy without unsafe-inline and unsafe-eval <code>script-src</code>s) will also help mitigate the risk.

References

  • https://bugzilla.mozilla.org/show_bug.cgi?id=1689399
  • https://advisory.checkmarx.net/advisory/CX-2021-4303
  • https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-23980
  • https://cure53.de/fp170.pdf

Credits

  • Reported by Yaniv Nizry from the CxSCA AppSec group at Checkmarx
  • Additional eject tags not mentioned in the original advisory and the CSP mitigation line being truncated in the revised advisory reported by MichaƂ Bentkowski at Securitum

For more information

If you have any questions or comments about this advisory:

References

Affected packages

PyPI / bleach

bleach

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0
Fixed
3.3.0

Affected versions

0.*

0.1
0.1.1
0.1.2
0.2
0.2.1
0.2.2
0.3
0.3.1
0.3.3
0.3.4
0.5.0
0.5.1

1.*

1.0.0
1.0.1
1.0.2
1.0.3
1.0.4
1.1.0
1.1.1
1.1.2
1.1.3
1.1.4
1.1.5
1.2
1.2.1
1.2.2
1.4
1.4.1
1.4.2
1.4.3
1.5.0

2.*

2.0.0
2.1
2.1.1
2.1.2
2.1.3
2.1.4

3.*

3.0.0
3.0.1
3.0.2
3.1.0
3.1.1
3.1.2
3.1.3
3.1.4
3.1.5
3.2.0
3.2.1
3.2.2
3.2.3

Ecosystem specific

{
    "affected_functions": [
        "bleach.clean"
    ]
}