GHSA-x277-3wcg-g9r2

Suggest an improvement
Source
https://github.com/advisories/GHSA-x277-3wcg-g9r2
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-x277-3wcg-g9r2/GHSA-x277-3wcg-g9r2.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-x277-3wcg-g9r2
Aliases
Published
2026-11-18T20:41:46Z
Modified
2026-11-18T21:00:39Z
Severity
  • 8.7 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:H/I:H/A:N CVSS Calculator
Summary
Atomic Server: Stored XSS via uploaded files served inline (same-origin) on `/download` → account takeover
Details

Summary

Files uploaded via POST /upload are served back by GET /download/{path} using actix_files::NamedFile. For text/html and image/svg+xml, actix-files (0.6.6) sets Content-Disposition: inline, so the browser renders the file instead of downloading it. The /download route sets no Content-Security-Policy, no X-Content-Type-Options: nosniff, and no forced attachment (CSP exists only on the SPA route), and files are served from the same origin as the app UI. An authenticated Agent uploads evil.html containing <script>; when a victim opens the link, the script executes in the app origin. Because the atomic_session cookie is set via document.cookie (not HttpOnly) and the Agent's Ed25519 private key is stored in same-origin IndexedDB (browser/data-browser/src/helpers/agentStorage.ts), the script exfiltrates the private key → permanent account takeover.

Affected component

  • server/src/handlers/upload.rs — stores the file; mimetype guessed from extension.
  • server/src/handlers/download.rs:65 — NamedFile::open(...).into_response(req) with no CSP/nosniff/attachment; CSP is only set in server/src/handlers/single_page_app.rs.

Steps to Reproduce

Environment: joepmeneer/atomic-server:develop, http://localhost:9883. Attacker is any Agent with write on a folder.

  1. Upload an HTML file (multipart, with signed auth headers):
POST /upload?parent=http://localhost:9883 HTTP/1.1
Host: localhost:9883
x-atomic-public-key: <pubkey>
x-atomic-agent: http://localhost:9883/agents/<pubkey>
x-atomic-timestamp: <ms>
x-atomic-signature: <ed25519("http://localhost:9883/upload?parent=http://localhost:9883 <ms>")>
Content-Type: multipart/form-data; boundary=----poc

------poc
Content-Disposition: form-data; name="assets"; filename="xss.html"
Content-Type: text/html

<html><body><script>alert(document.domain)</script>STORED-XSS-PROOF</body></html>
------poc--

Response 200 returns a downloadURL, e.g. http://localhost:9883/download/files/<ts>-xss.html.

  1. Inspect how the server serves it:
$ curl -D - http://localhost:9883/download/files/<ts>-xss.html
HTTP/1.1 200 OK
content-type: text/html; charset=utf-8
content-disposition: inline; filename="<ts>-xss.html"
# (no Content-Security-Policy, no X-Content-Type-Options)

text/html + inline + no CSP/nosniff + same origin → the browser executes the uploaded HTML/JS in the app origin. image/svg+xml behaves identically.

  1. The attacker sends the link to a victim. On open, the script runs same-origin and reads document.cookie (session is not HttpOnly) and the Ed25519 private key from IndexedDB → signs Commits as the victim indefinitely.

Expected: user files served with Content-Disposition: attachment + nosniff, or from an isolated origin. Actual: served inline, text/html, same origin, no CSP/nosniff → stored XSS executes.

(Confirmed at the HTTP layer in the lab: content-type, disposition, missing CSP/nosniff, same origin, and the intact <script> body. In-browser execution and IndexedDB key theft follow directly from these response headers.)

Impact

Stored XSS in the app origin → theft of the victim's session cookie (not HttpOnly) and Ed25519 private key from IndexedDB → permanent account takeover (not limited by the 10-second token window). If the victim is an admin/root Agent, this is server takeover.

Remediation

  • On /download, force Content-Disposition: attachment for user files, add X-Content-Type-Options: nosniff, and a sandbox CSP.
  • Serve user-uploaded files from a separate origin/subdomain.
  • Set HttpOnly + Secure on the session cookie; do not persist the private key in JS-readable storage.
Database specific
{
    "cwe_ids": [
        "CWE-79"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2026-11-18T20:41:46Z",
    "nvd_published_at": "2026-11-17T21:18:12Z",
    "severity": "HIGH"
}
References

Affected packages

crates.io / atomic-server

Package

Name
atomic-server
View open source insights on deps.dev
Purl
pkg:cargo/atomic-server

Affected ranges

Type
SEMVER
Events
Introduced
0.30.0
Last Affected
0.40.1

Database specific

source
"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-x277-3wcg-g9r2/GHSA-x277-3wcg-g9r2.json"