GHSA-xfhw-6mc4-mgxf

Suggest an improvement
Source
https://github.com/advisories/GHSA-xfhw-6mc4-mgxf
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-xfhw-6mc4-mgxf/GHSA-xfhw-6mc4-mgxf.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-xfhw-6mc4-mgxf
Aliases
Published
2024-04-05T15:40:40Z
Modified
2024-04-11T16:41:43.882509Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
Summary
crayon: ObjectPool creates uninitialized memory when freeing objects
Details

As of version 0.6.0, the ObjectPool explicitly creates an uninitialized instance of its type parameter when it attempts to free an object, and swaps it into the storage. This causes instant undefined behavior due to reading the uninitialized memory in order to write it to the pool storage.

Extremely basic usage of the crate can trigger this issue, e.g. this code from a doctest:

use crayon::prelude::*;
application::oneshot().unwrap();

let mut params = MeshParams::default();

let mesh = video::create_mesh(params, None).unwrap();

// Deletes the mesh object.
video::delete_mesh(mesh); // <-- UB

The Clippy warning for this code was silenced in commit c2fde19caf6149d91faa504263f0bc5cafc35de5.

Discovered via https://asan.saethlin.dev/ub?crate=crayon&version=0.7.1

Database specific
{
    "nvd_published_at": null,
    "cwe_ids": [
        "CWE-908"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2024-04-05T15:40:40Z"
}
References

Affected packages

crates.io / crayon

Package

Affected ranges

Type
SEMVER
Events
Introduced
0.6.0
Last affected
0.7.1