CSRF vulnerability that allows user account takeover.
All applications using any version of the frontend component of solidus_auth_devise are affected if protect_from_forgery method is both:
- Executed whether as:
- A before_action callback (the default)
- A prepend_before_action (option prepend: true given) before the :load_object hook in Spree::UserController (most likely order to find).
- Configured to use :null_session or :reset_session strategies (:null_session is the default in case the no strategy is given, but rails --new generated skeleton use :exception).
That means that applications that haven't been configured differently from what it's generated with Rails aren't affected.
Users should promptly update to solidus_auth_devise version 2.5.4.
A couple of options:
If possible, change your strategy to :exception:
class ApplicationController < ActionController::Base
protect_from_forgery with: :exception
end
Add the following to config/application.rb to at least run the :exception strategy on the affected controller:
config.after_initialize do
Spree::UsersController.protect_from_forgery with: :exception
end
We've also released new Solidus versions monkey patching solidus_auth_devise with the quick fix. Those versions are v3.1.3, v.3.0.3 & v2.11.12. See GHSA-5629-8855-gf4g for details.
We'd like to thank vampire000 for reporting this issue.
If you have any questions or comments about this advisory: * Open an issue in solidusauthdevise or a discussion in solidus * Email us at security@solidus.io * Contact the core team on Slack
{
"github_reviewed_at": "2021-11-17T19:57:48Z",
"github_reviewed": true,
"cwe_ids": [
"CWE-352"
],
"nvd_published_at": "2021-11-17T20:15:00Z",
"severity": "CRITICAL"
}