GHSA-xrc4-737v-9q75

Suggest an improvement
Source
https://github.com/advisories/GHSA-xrc4-737v-9q75
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/08/GHSA-xrc4-737v-9q75/GHSA-xrc4-737v-9q75.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-xrc4-737v-9q75
Aliases
Related
Published
2022-08-18T18:48:41Z
Modified
2023-11-08T04:09:29.869695Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N CVSS Calculator
Summary
OpenZeppelin Contracts's GovernorVotesQuorumFraction updates to quorum may affect past defeated proposals
Details

Impact

This issue concerns instances of Governor that use the module GovernorVotesQuorumFraction, a mechanism that determines quorum requirements as a percentage of the voting token's total supply. In affected instances, when a proposal is passed to lower the quorum requirement, past proposals may become executable if they had been defeated only due to lack of quorum, and the number of votes it received meets the new quorum requirement.

Analysis of instances on chain found only one proposal that met this condition, and we are actively monitoring for new occurrences of this particular issue.

Patches

This issue has been patched in v4.7.2.

Workarounds

Avoid lowering quorum requirements if a past proposal was defeated for lack of quorum.

References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3561

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at security@openzeppelin.com.

Database specific
{
    "github_reviewed": true,
    "cwe_ids": [
        "CWE-682"
    ],
    "severity": "HIGH",
    "github_reviewed_at": "2022-08-18T18:48:41Z",
    "nvd_published_at": "2022-08-01T21:15:00Z"
}
References

Affected packages

npm / @openzeppelin/contracts

Package

Name
@openzeppelin/contracts
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts

Affected ranges

Type
SEMVER
Events
Introduced
4.3.0
Fixed
4.7.2

npm / @openzeppelin/contracts-upgradeable

Package

Name
@openzeppelin/contracts-upgradeable
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts-upgradeable

Affected ranges

Type
SEMVER
Events
Introduced
4.3.0
Fixed
4.7.2