RUSTSEC-2020-0161

Source
https://rustsec.org/advisories/RUSTSEC-2020-0161
Import Source
https://github.com/rustsec/advisory-db/blob/osv/crates/RUSTSEC-2020-0161.json
JSON Data
https://api.osv.dev/v1/vulns/RUSTSEC-2020-0161
Aliases
Published
2020-05-07T12:00:00Z
Modified
2023-11-08T04:17:08.031225Z
Summary
`array!` macro is unsound in presence of traits that implement methods it calls internally
Details

Affected versions of this crate called some methods using auto-ref. The affected code looked like this.

let mut arr = $crate::__core::mem::MaybeUninit::uninit();
let mut vec = $crate::__ArrayVec::<T>::new(arr.as_mut_ptr() as *mut T);

In this case, the problem is that as_mut_ptr is a method of &mut MaybeUninit, not MaybeUninit. This made it possible for traits to hijack the method calls in order to cause unsoundness.

trait AsMutPtr<T> {
    fn as_mut_ptr(&self) -> *mut T;
}
impl<T> AsMutPtr<T> for std::mem::MaybeUninit<T> {
    fn as_mut_ptr(&self) -> *mut T {
        std::ptr::null_mut()
    }
}
array![0; 1];

The flaw was corrected by explicitly referencing variables in macro body in order to avoid auto-ref.

Database specific
{
    "license": "CC0-1.0"
}
References

Affected packages

crates.io / array-macro

Package

Affected ranges

Type
SEMVER
Events
Introduced
0.1.2
Fixed
1.0.5

Ecosystem specific

{
    "affected_functions": null,
    "affects": {
        "os": [],
        "functions": [],
        "arch": []
    }
}

Database specific

{
    "cvss": null,
    "informational": "unsound",
    "categories": [
        "memory-corruption"
    ]
}