In the Linux kernel, the following vulnerability has been resolved:
SUNRPC: Fix UAF in svctcplistendataready()
After the listener svcsock is freed, and before invoking svctcpaccept() for the established child sock, there is a window that the newsock retaining a freed listener svcsock in skuserdata which cloning from parent. In the race window, if data is received on the newsock, we will observe use-after-free report in svctcplistendataready().
Reproduce by two tasks:
KASAN report:
================================================================== BUG: KASAN: slab-use-after-free in svctcplistendataready+0x1cf/0x1f0 [sunrpc] Read of size 8 at addr ffff888139d96228 by task nc/102553 CPU: 7 PID: 102553 Comm: nc Not tainted 6.3.0+ #18 Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020 Call Trace: <IRQ> dumpstacklvl+0x33/0x50 printaddressdescription.constprop.0+0x27/0x310 printreport+0x3e/0x70 kasanreport+0xae/0xe0 svctcplistendataready+0x1cf/0x1f0 [sunrpc] tcpdataqueue+0x9f4/0x20e0 tcprcvestablished+0x666/0x1f60 tcpv4dorcv+0x51c/0x850 tcpv4rcv+0x23fc/0x2e80 ipprotocoldeliverrcu+0x62/0x300 iplocaldeliverfinish+0x267/0x350 iplocaldeliver+0x18b/0x2d0 iprcv+0x2fb/0x370 _netifreceiveskbonecore+0x166/0x1b0 processbacklog+0x24c/0x5e0 _napipoll+0xa2/0x500 netrxaction+0x854/0xc90 _dosoftirq+0x1bb/0x5de do_softirq+0xcb/0x100 </IRQ> <TASK> ... </TASK>
Allocated by task 102371: kasansavestack+0x1e/0x40 kasansettrack+0x21/0x30 _kasankmalloc+0x7b/0x90 svcsetupsocket+0x52/0x4f0 [sunrpc] svcaddsock+0x20d/0x400 [sunrpc] _writeportsaddfd+0x209/0x390 [nfsd] writeports+0x239/0x2c0 [nfsd] nfsctltransactionwrite+0xac/0x110 [nfsd] vfswrite+0x1c3/0xae0 ksyswrite+0xed/0x1c0 dosyscall64+0x38/0x90 entrySYSCALL64after_hwframe+0x72/0xdc
Freed by task 102551: kasansavestack+0x1e/0x40 kasansettrack+0x21/0x30 kasansavefreeinfo+0x2a/0x50 _kasanslabfree+0x106/0x190 _kmemcachefree+0x133/0x270 svcxprtfree+0x1e2/0x350 [sunrpc] svcxprtdestroyall+0x25a/0x440 [sunrpc] nfsdput+0x125/0x240 [nfsd] nfsdsvc+0x2cb/0x3c0 [nfsd] writethreads+0x1ac/0x2a0 [nfsd] nfsctltransactionwrite+0xac/0x110 [nfsd] vfswrite+0x1c3/0xae0 ksyswrite+0xed/0x1c0 dosyscall64+0x38/0x90 entrySYSCALL64after_hwframe+0x72/0xdc
Fix the UAF by simply doing nothing in svctcplistendataready() if state != TCP_LISTEN, that will avoid dereferencing svsk for all child socket.
[
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fbf4ace39b2e4f3833236afbb2336edbafd75eee",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-02013470",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 296.0,
"function_hash": "56225728256830516867358866850362245516"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fc80fc2d4e39137869da3150ee169b40bf879287",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-03f50547",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 317.0,
"function_hash": "340121360367253726520684551145273042476"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c7b8c2d06e437639694abe76978e915cfb73f428",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-0e4b4dcf",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 448.0,
"function_hash": "163781101434456107533967323314881319971"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@dfc896c4a75cb8cd7cb2dfd9b469cf1e3f004254",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-1076a9c3",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 448.0,
"function_hash": "163781101434456107533967323314881319971"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@7e1f989055622fd086c5dfb291fc72adf5660b6f",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-19e5e8bc",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 317.0,
"function_hash": "340121360367253726520684551145273042476"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c7b8c2d06e437639694abe76978e915cfb73f428",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-1f643980",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"141845282037712955629587525501715973136",
"175897549045159159293873178085440694416",
"262381393357958971205765320999829677343",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"111556299130026823670741208603313269147",
"5292787364786200105257138073430616933",
"165242719863746440360601597060588130610",
"208876753206670942567486911460126785718",
"335753823338140151974674111107489399821",
"147719566682924724960228684106783035464"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fc80fc2d4e39137869da3150ee169b40bf879287",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-382d9234",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"11706627628530476327597448055430573344",
"15109181335997226369925378629844750876",
"192299625866415249738315686729410048693",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"35418841074251854215744245841674607984",
"153054654784250714401677537965635506727",
"308085804197074493151063481551243986630",
"84767024874337357245222341609710216617"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@42725e5c1b181b757ba11d804443922982334d9b",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-568eacf9",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 448.0,
"function_hash": "163781101434456107533967323314881319971"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@cd5ec3ee52ce4b7e283cc11facfa420c297c8065",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-5b1ba1e4",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"245451743635254781141977739704618294026",
"51437545037871292476390794368706688397",
"297890799004166241717236227168470662736",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"35418841074251854215744245841674607984",
"153054654784250714401677537965635506727",
"308085804197074493151063481551243986630",
"84767024874337357245222341609710216617"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@42725e5c1b181b757ba11d804443922982334d9b",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-751f0365",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"141845282037712955629587525501715973136",
"175897549045159159293873178085440694416",
"262381393357958971205765320999829677343",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"111556299130026823670741208603313269147",
"5292787364786200105257138073430616933",
"165242719863746440360601597060588130610",
"208876753206670942567486911460126785718",
"335753823338140151974674111107489399821",
"147719566682924724960228684106783035464"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@7e1f989055622fd086c5dfb291fc72adf5660b6f",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-78efaf4e",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"11706627628530476327597448055430573344",
"15109181335997226369925378629844750876",
"192299625866415249738315686729410048693",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"35418841074251854215744245841674607984",
"153054654784250714401677537965635506727",
"308085804197074493151063481551243986630",
"84767024874337357245222341609710216617"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ef047411887ff0845afd642d6a687819308e1a4e",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-896b3d8f",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 296.0,
"function_hash": "56225728256830516867358866850362245516"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@dfc896c4a75cb8cd7cb2dfd9b469cf1e3f004254",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-a070b7e1",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"141845282037712955629587525501715973136",
"175897549045159159293873178085440694416",
"262381393357958971205765320999829677343",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"111556299130026823670741208603313269147",
"5292787364786200105257138073430616933",
"165242719863746440360601597060588130610",
"208876753206670942567486911460126785718",
"335753823338140151974674111107489399821",
"147719566682924724960228684106783035464"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@fbf4ace39b2e4f3833236afbb2336edbafd75eee",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-a26bb807",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"245451743635254781141977739704618294026",
"51437545037871292476390794368706688397",
"297890799004166241717236227168470662736",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"35418841074251854215744245841674607984",
"153054654784250714401677537965635506727",
"308085804197074493151063481551243986630",
"84767024874337357245222341609710216617"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ef047411887ff0845afd642d6a687819308e1a4e",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-a663866a",
"target": {
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"245451743635254781141977739704618294026",
"51437545037871292476390794368706688397",
"297890799004166241717236227168470662736",
"289857309575669879528210238102973399963",
"291216276066305501216937954992748813533",
"163463660938904053521505263748687705032",
"307716327904243259402107400515601622814",
"120637793458391313088549155684075312092",
"35418841074251854215744245841674607984",
"153054654784250714401677537965635506727",
"308085804197074493151063481551243986630",
"84767024874337357245222341609710216617"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@cd5ec3ee52ce4b7e283cc11facfa420c297c8065",
"signature_version": "v1",
"deprecated": false,
"id": "CVE-2023-52885-ce0f96b1",
"target": {
"function": "svc_tcp_listen_data_ready",
"file": "net/sunrpc/svcsock.c"
},
"signature_type": "Function",
"digest": {
"length": 296.0,
"function_hash": "56225728256830516867358866850362245516"
}
}
]