CVE-2023-53536

If blkcryptoevictkey() sees that the key is still in-use (due to a bug) or that ->keyslotevict failed, it currently just returns while leaving the key linked into the keyslot management structures.

However, blkcryptoevictkey() is only called in contexts such as inode eviction where failure is not an option. So actually the caller proceeds with freeing the blkcryptokey regardless of the return value of blkcryptoevictkey().

These two assumptions don't match, and the result is that there can be a use-after-free in blkcryptoreprogramallkeys() after one of these errors occurs. (Note, these errors shouldn't happen; we're just talking about what happens if they do anyway.)

Fix this by making blkcryptoevict_key() unlink the key from the keyslot management structures even on failure.

Also improve some comments.

Database specific

{
    "cna_assigner": "Linux",
    "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2023/53xxx/CVE-2023-53536.json"
}

References

Affected packages

Git / git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git

Affected ranges

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

1b2628397058ebce7277480960b29c788138de90

Fixed

701a8220762ff90615dc91d3543f789391b63298

Fixed

5bb4005fb667c6e2188fa87950f8d5faf2994410

Fixed

64ef787bb1588475163069c2e62fdd8f6c27b1f6

Fixed

809a5be62e92a444a3c3d7b9f438019d0b322f55

Fixed

5c62852942667c613de0458fc797c5b8c36112b5

Fixed

5c7cb94452901a93e90c2230632e2c12a681bc92

Affected versions

v5.*

v5.10

v5.10-rc1

v5.10-rc2

v5.10-rc3

v5.10-rc4

v5.10-rc5

v5.10-rc6

v5.10-rc7

v5.10.1

v5.10.10

v5.10.100

v5.10.101

v5.10.102

v5.10.103

v5.10.104

v5.10.105

v5.10.106

v5.10.107

v5.10.108

v5.10.109

v5.10.11

v5.10.110

v5.10.111

v5.10.112

v5.10.113

v5.10.114

v5.10.115

v5.10.116

v5.10.117

v5.10.118

v5.10.119

v5.10.12

v5.10.120

v5.10.121

v5.10.122

v5.10.123

v5.10.124

v5.10.125

v5.10.126

v5.10.127

v5.10.128

v5.10.129

v5.10.13

v5.10.130

v5.10.131

v5.10.132

v5.10.133

v5.10.134

v5.10.135

v5.10.136

v5.10.137

v5.10.138

v5.10.139

v5.10.14

v5.10.140

v5.10.141

v5.10.142

v5.10.143

v5.10.144

v5.10.145

v5.10.146

v5.10.147

v5.10.148

v5.10.149

v5.10.15

v5.10.150

v5.10.151

v5.10.152

v5.10.153

v5.10.154

v5.10.155

v5.10.156

v5.10.157

v5.10.158

v5.10.159

v5.10.16

v5.10.160

v5.10.161

v5.10.162

v5.10.163

v5.10.164

v5.10.165

v5.10.166

v5.10.167

v5.10.168

v5.10.169

v5.10.17

v5.10.170

v5.10.171

v5.10.172

v5.10.173

v5.10.174

v5.10.175

v5.10.176

v5.10.177

v5.10.178

v5.10.179

v5.10.18

v5.10.19

v5.10.2

v5.10.20

v5.10.21

v5.10.22

v5.10.23

v5.10.24

v5.10.25

v5.10.26

v5.10.27

v5.10.28

v5.10.29

v5.10.3

v5.10.30

v5.10.31

v5.10.32

v5.10.33

v5.10.34

v5.10.35

v5.10.36

v5.10.37

v5.10.38

v5.10.39

v5.10.4

v5.10.40

v5.10.41

v5.10.42

v5.10.43

v5.10.44

v5.10.45

v5.10.46

v5.10.47

v5.10.48

v5.10.49

v5.10.5

v5.10.50

v5.10.51

v5.10.52

v5.10.53

v5.10.54

v5.10.55

v5.10.56

v5.10.57

v5.10.58

v5.10.59

v5.10.6

v5.10.60

v5.10.61

v5.10.62

v5.10.63

v5.10.64

v5.10.65

v5.10.66

v5.10.67

v5.10.68

v5.10.69

v5.10.7

v5.10.70

v5.10.71

v5.10.72

v5.10.73

v5.10.74

v5.10.75

v5.10.76

v5.10.77

v5.10.78

v5.10.79

v5.10.8

v5.10.80

v5.10.81

v5.10.82

v5.10.83

v5.10.84

v5.10.85

v5.10.86

v5.10.87

v5.10.88

v5.10.89

v5.10.9

v5.10.90

v5.10.91

v5.10.92

v5.10.93

v5.10.94

v5.10.95

v5.10.96

v5.10.97

v5.10.98

v5.10.99

v5.11

v5.11-rc1

v5.11-rc2

v5.11-rc3

v5.11-rc4

v5.11-rc5

v5.11-rc6

v5.11-rc7

v5.12

v5.12-rc1

v5.12-rc1-dontuse

v5.12-rc2

v5.12-rc3

v5.12-rc4

v5.12-rc5

v5.12-rc6

v5.12-rc7

v5.12-rc8

v5.13

v5.13-rc1

v5.13-rc2

v5.13-rc3

v5.13-rc4

v5.13-rc5

v5.13-rc6

v5.13-rc7

v5.14

v5.14-rc1

v5.14-rc2

v5.14-rc3

v5.14-rc4

v5.14-rc5

v5.14-rc6

v5.14-rc7

v5.15

v5.15-rc1

v5.15-rc2

v5.15-rc3

v5.15-rc4

v5.15-rc5

v5.15-rc6

v5.15-rc7

v5.15.1

v5.15.10

v5.15.100

v5.15.101

v5.15.102

v5.15.103

v5.15.104

v5.15.105

v5.15.106

v5.15.107

v5.15.108

v5.15.109

v5.15.11

v5.15.110

v5.15.12

v5.15.13

v5.15.14

v5.15.15

v5.15.16

v5.15.17

v5.15.18

v5.15.19

v5.15.2

v5.15.20

v5.15.21

v5.15.22

v5.15.23

v5.15.24

v5.15.25

v5.15.26

v5.15.27

v5.15.28

v5.15.29

v5.15.3

v5.15.30

v5.15.31

v5.15.32

v5.15.33

v5.15.34

v5.15.35

v5.15.36

v5.15.37

v5.15.38

v5.15.39

v5.15.4

v5.15.40

v5.15.41

v5.15.42

v5.15.43

v5.15.44

v5.15.45

v5.15.46

v5.15.47

v5.15.48

v5.15.49

v5.15.5

v5.15.50

v5.15.51

v5.15.52

v5.15.53

v5.15.54

v5.15.55

v5.15.56

v5.15.57

v5.15.58

v5.15.59

v5.15.6

v5.15.60

v5.15.61

v5.15.62

v5.15.63

v5.15.64

v5.15.65

v5.15.66

v5.15.67

v5.15.68

v5.15.69

v5.15.7

v5.15.70

v5.15.71

v5.15.72

v5.15.73

v5.15.74

v5.15.75

v5.15.76

v5.15.77

v5.15.78

v5.15.79

v5.15.8

v5.15.80

v5.15.81

v5.15.82

v5.15.83

v5.15.84

v5.15.85

v5.15.86

v5.15.87

v5.15.88

v5.15.89

v5.15.9

v5.15.90

v5.15.91

v5.15.92

v5.15.93

v5.15.94

v5.15.95

v5.15.96

v5.15.97

v5.15.98

v5.15.99

v5.16

v5.16-rc1

v5.16-rc2

v5.16-rc3

v5.16-rc4

v5.16-rc5

v5.16-rc6

v5.16-rc7

v5.16-rc8

v5.17

v5.17-rc1

v5.17-rc2

v5.17-rc3

v5.17-rc4

v5.17-rc5

v5.17-rc6

v5.17-rc7

v5.17-rc8

v5.18

v5.18-rc1

v5.18-rc2

v5.18-rc3

v5.18-rc4

v5.18-rc5

v5.18-rc6

v5.18-rc7

v5.19

v5.19-rc1

v5.19-rc2

v5.19-rc3

v5.19-rc4

v5.19-rc5

v5.19-rc6

v5.19-rc7

v5.19-rc8

v5.7

v5.7-rc3

v5.7-rc4

v5.7-rc5

v5.7-rc6

v5.7-rc7

v5.8

v5.8-rc1

v5.8-rc2

v5.8-rc3

v5.8-rc4

v5.8-rc5

v5.8-rc6

v5.8-rc7

v5.9

v5.9-rc1

v5.9-rc2

v5.9-rc3

v5.9-rc4

v5.9-rc5

v5.9-rc6

v5.9-rc7

v5.9-rc8

v6.*

v6.0

v6.0-rc1

v6.0-rc2

v6.0-rc3

v6.0-rc4

v6.0-rc5

v6.0-rc6

v6.0-rc7

v6.1

v6.1-rc1

v6.1-rc2

v6.1-rc3

v6.1-rc4

v6.1-rc5

v6.1-rc6

v6.1-rc7

v6.1-rc8

v6.1.1

v6.1.10

v6.1.11

v6.1.12

v6.1.13

v6.1.14

v6.1.15

v6.1.16

v6.1.17

v6.1.18

v6.1.19

v6.1.2

v6.1.20

v6.1.21

v6.1.22

v6.1.23

v6.1.24

v6.1.25

v6.1.26

v6.1.27

v6.1.3

v6.1.4

v6.1.5

v6.1.6

v6.1.7

v6.1.8

v6.1.9

v6.2

v6.2-rc1

v6.2-rc2

v6.2-rc3

v6.2-rc4

v6.2-rc5

v6.2-rc6

v6.2-rc7

v6.2-rc8

v6.2.1

v6.2.10

v6.2.11

v6.2.12

v6.2.13

v6.2.14

v6.2.2

v6.2.3

v6.2.4

v6.2.5

v6.2.6

v6.2.7

v6.2.8

v6.2.9

v6.3

v6.3-rc1

v6.3-rc2

v6.3-rc3

v6.3-rc4

v6.3-rc5

v6.3-rc6

v6.3-rc7

v6.3.1

Database specific

vanir_signatures

[
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "256728442921684661202936218592646212507",
                "63493517373524762021423305343165798202",
                "239202972851044992597937054505442579424",
                "154379555189487615281669966615328515150",
                "322816854319008337575194563201225185113",
                "139416476275477756776801933027138024572",
                "175668761061036443105025092870874810702",
                "24458314370969366149397805998667838668",
                "149506888980509292287831330931941920156",
                "174174354282710759353433543884447129891",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "237893674747395372639455320637082719254",
                "35688589923891801085423947310451891943",
                "300572066619201559430554802685066832670",
                "86249138167211020984511322281240465758",
                "168039181185951224818374720358190589503",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "301707668426434306126134873920559783982",
                "294513299792946458948513424117177698520",
                "256668440286215236305284087824935346771"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@701a8220762ff90615dc91d3543f789391b63298",
        "deprecated": false,
        "id": "CVE-2023-53536-060e7c0e",
        "signature_type": "Line",
        "target": {
            "file": "block/keyslot-manager.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 697.0,
            "function_hash": "171686787087380215140808104830353505546"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5c62852942667c613de0458fc797c5b8c36112b5",
        "deprecated": false,
        "id": "CVE-2023-53536-12573c2e",
        "signature_type": "Function",
        "target": {
            "function": "__blk_crypto_evict_key",
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 697.0,
            "function_hash": "171686787087380215140808104830353505546"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@64ef787bb1588475163069c2e62fdd8f6c27b1f6",
        "deprecated": false,
        "id": "CVE-2023-53536-3151cdb5",
        "signature_type": "Function",
        "target": {
            "function": "__blk_crypto_evict_key",
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "183959274913330872485755337164751055035",
                "274411969350279899400011828080554147357",
                "208344508992798606944863222747038155026",
                "149310753214627131690236793454347707071",
                "247729808690044244033780144393297164970",
                "251179905474685329116745153227651918665",
                "41814942102132550106002675901449616068",
                "220850083350022247030770367845458169245",
                "189264620961780764416196318170271232337",
                "211812969945269599652263080817087401630",
                "162539103802388676582988247140744901145",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "17297083101967065642394264260087287557",
                "183429715329790720985779312030176060110",
                "322190149774111037972400763629653582694",
                "269324410383188941926211857396794391253",
                "195209717630960336432309001368408094631",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "305385070603030131585952177428928609142",
                "298131256301351992271228911409097977214",
                "183193684187368596534386681078950345923"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@64ef787bb1588475163069c2e62fdd8f6c27b1f6",
        "deprecated": false,
        "id": "CVE-2023-53536-3e11cfc2",
        "signature_type": "Line",
        "target": {
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "256728442921684661202936218592646212507",
                "63493517373524762021423305343165798202",
                "239202972851044992597937054505442579424",
                "154379555189487615281669966615328515150",
                "322816854319008337575194563201225185113",
                "227889870003321662781221681156162258594",
                "132787033773226867359849918147947802554",
                "13808617623586111717141264112721019867",
                "307544905973993170381365574330880506045",
                "149506888980509292287831330931941920156",
                "174174354282710759353433543884447129891",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "237893674747395372639455320637082719254",
                "35688589923891801085423947310451891943",
                "300572066619201559430554802685066832670",
                "86249138167211020984511322281240465758",
                "168039181185951224818374720358190589503",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "301707668426434306126134873920559783982",
                "294513299792946458948513424117177698520",
                "256668440286215236305284087824935346771"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5bb4005fb667c6e2188fa87950f8d5faf2994410",
        "deprecated": false,
        "id": "CVE-2023-53536-49314ac1",
        "signature_type": "Line",
        "target": {
            "file": "block/keyslot-manager.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 493.0,
            "function_hash": "184791628891833111874625881186672595666"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@701a8220762ff90615dc91d3543f789391b63298",
        "deprecated": false,
        "id": "CVE-2023-53536-4f3f2a23",
        "signature_type": "Function",
        "target": {
            "function": "blk_ksm_evict_key",
            "file": "block/keyslot-manager.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "183959274913330872485755337164751055035",
                "274411969350279899400011828080554147357",
                "208344508992798606944863222747038155026",
                "149310753214627131690236793454347707071",
                "247729808690044244033780144393297164970",
                "251179905474685329116745153227651918665",
                "41814942102132550106002675901449616068",
                "220850083350022247030770367845458169245",
                "189264620961780764416196318170271232337",
                "211812969945269599652263080817087401630",
                "162539103802388676582988247140744901145",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "17297083101967065642394264260087287557",
                "183429715329790720985779312030176060110",
                "322190149774111037972400763629653582694",
                "269324410383188941926211857396794391253",
                "195209717630960336432309001368408094631",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "305385070603030131585952177428928609142",
                "298131256301351992271228911409097977214",
                "183193684187368596534386681078950345923"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5c62852942667c613de0458fc797c5b8c36112b5",
        "deprecated": false,
        "id": "CVE-2023-53536-615f5c2b",
        "signature_type": "Line",
        "target": {
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "183959274913330872485755337164751055035",
                "274411969350279899400011828080554147357",
                "208344508992798606944863222747038155026",
                "149310753214627131690236793454347707071",
                "247729808690044244033780144393297164970",
                "251179905474685329116745153227651918665",
                "41814942102132550106002675901449616068",
                "220850083350022247030770367845458169245",
                "189264620961780764416196318170271232337",
                "211812969945269599652263080817087401630",
                "162539103802388676582988247140744901145",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "17297083101967065642394264260087287557",
                "183429715329790720985779312030176060110",
                "322190149774111037972400763629653582694",
                "269324410383188941926211857396794391253",
                "195209717630960336432309001368408094631",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "305385070603030131585952177428928609142",
                "298131256301351992271228911409097977214",
                "183193684187368596534386681078950345923"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5c7cb94452901a93e90c2230632e2c12a681bc92",
        "deprecated": false,
        "id": "CVE-2023-53536-7d1475cf",
        "signature_type": "Line",
        "target": {
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 704.0,
            "function_hash": "40350122262028520058226124433743787992"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5bb4005fb667c6e2188fa87950f8d5faf2994410",
        "deprecated": false,
        "id": "CVE-2023-53536-82c51d0f",
        "signature_type": "Function",
        "target": {
            "function": "blk_ksm_evict_key",
            "file": "block/keyslot-manager.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 697.0,
            "function_hash": "171686787087380215140808104830353505546"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5c7cb94452901a93e90c2230632e2c12a681bc92",
        "deprecated": false,
        "id": "CVE-2023-53536-979355ae",
        "signature_type": "Function",
        "target": {
            "function": "__blk_crypto_evict_key",
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "length": 697.0,
            "function_hash": "171686787087380215140808104830353505546"
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@809a5be62e92a444a3c3d7b9f438019d0b322f55",
        "deprecated": false,
        "id": "CVE-2023-53536-9fc0279e",
        "signature_type": "Function",
        "target": {
            "function": "__blk_crypto_evict_key",
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    },
    {
        "digest": {
            "threshold": 0.9,
            "line_hashes": [
                "183959274913330872485755337164751055035",
                "274411969350279899400011828080554147357",
                "208344508992798606944863222747038155026",
                "149310753214627131690236793454347707071",
                "247729808690044244033780144393297164970",
                "251179905474685329116745153227651918665",
                "41814942102132550106002675901449616068",
                "220850083350022247030770367845458169245",
                "189264620961780764416196318170271232337",
                "211812969945269599652263080817087401630",
                "162539103802388676582988247140744901145",
                "269759944633370978837710773089782763155",
                "63014778952494747837860601888234169204",
                "11703695103120766454859765738958361823",
                "17297083101967065642394264260087287557",
                "183429715329790720985779312030176060110",
                "322190149774111037972400763629653582694",
                "269324410383188941926211857396794391253",
                "195209717630960336432309001368408094631",
                "136004125037973858009881080723002870613",
                "77134965002571770241822764680364297291",
                "81530959042037373511282429016777137788",
                "305385070603030131585952177428928609142",
                "298131256301351992271228911409097977214",
                "183193684187368596534386681078950345923"
            ]
        },
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@809a5be62e92a444a3c3d7b9f438019d0b322f55",
        "deprecated": false,
        "id": "CVE-2023-53536-a6609dfc",
        "signature_type": "Line",
        "target": {
            "file": "block/blk-crypto-profile.c"
        },
        "signature_version": "v1"
    }
]

source

"https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2023-53536.json"

Git / github.com/gregkh/linux