In the Linux kernel, the following vulnerability has been resolved:
ALSA: core: Fix NULL module pointer assignment at card init
The commit 81033c6b584b ("ALSA: core: Warn on empty module") introduced a WARNON() for a NULL module pointer passed at sndcard object creation, and it also wraps the code around it with '#ifdef MODULE'. This works in most cases, but the devils are always in details. "MODULE" is defined when the target code (i.e. the sound core) is built as a module; but this doesn't mean that the caller is also built-in or not. Namely, when only the sound core is built-in (CONFIGSND=y) while the driver is a module (CONFIGSNDUSBAUDIO=m), the passed module pointer is ignored even if it's non-NULL, and card->module remains as NULL. This would result in the missing module reference up/down at the device open/close, leading to a race with the code execution after the module removal.
For addressing the bug, move the assignment of card->module again out of ifdef. The WARN_ON() is still wrapped with ifdef because the module can be really NULL when all sound drivers are built-in.
Note that we keep 'ifdef MODULE' for WARNON(), otherwise it would lead to a false-positive NULL module check. Admittedly it won't catch perfectly, i.e. no check is performed when CONFIGSND=y. But, it's no real problem as it's only for debugging, and the condition is pretty rare.
{ "vanir_signatures": [ { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-2c8b0521", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e007476725730c1a68387b54b7629486d8a8301e" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-4099d30c", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e644036a3e2b2c9b3eee3c61b5d31c2ca8b5ba92" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-4c7f8d60", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e7e0ca200772bdb2fdc6d43d32d341e87a36f811" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-6c2b2f0c", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@d7ff29a429b56f04783152ad7bbd7233b740e434" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_new" }, "signature_version": "v1", "digest": { "length": 2541.0, "function_hash": "35220385178152785385318025112356413947" }, "id": "CVE-2024-38605-7b357c4d", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@d7ff29a429b56f04783152ad7bbd7233b740e434" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2755.0, "function_hash": "256291471023429991470262978503684961593" }, "id": "CVE-2024-38605-823fb584", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e644036a3e2b2c9b3eee3c61b5d31c2ca8b5ba92" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2813.0, "function_hash": "192942818396403780779244856579671484089" }, "id": "CVE-2024-38605-91fce5d1", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e007476725730c1a68387b54b7629486d8a8301e" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-acb246b7", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@39381fe7394e5eafac76e7e9367e7351138a29c1" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2722.0, "function_hash": "1168027152964915288040585526471781869" }, "id": "CVE-2024-38605-af3677fa", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@6b8374ee2cabcf034faa34e69a855dc496a9ec12" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-b8a497a2", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c935e72139e6d523defd60fe875c01eb1f9ea5c5" }, { "deprecated": false, "signature_type": "Line", "target": { "file": "sound/core/init.c" }, "signature_version": "v1", "digest": { "line_hashes": [ "286508510727595168778180965731488632142", "339842685924329305610975657630358925113", "276954004034006945071149808056397454572", "81024560988597541912545269224075013999", "304346717154941629780619408986009208894" ], "threshold": 0.9 }, "id": "CVE-2024-38605-ce091217", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@6b8374ee2cabcf034faa34e69a855dc496a9ec12" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2755.0, "function_hash": "256291471023429991470262978503684961593" }, "id": "CVE-2024-38605-defb91fb", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c935e72139e6d523defd60fe875c01eb1f9ea5c5" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2698.0, "function_hash": "40390154246267313645877339149184221030" }, "id": "CVE-2024-38605-f07c7440", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e7e0ca200772bdb2fdc6d43d32d341e87a36f811" }, { "deprecated": false, "signature_type": "Function", "target": { "file": "sound/core/init.c", "function": "snd_card_init" }, "signature_version": "v1", "digest": { "length": 2722.0, "function_hash": "1168027152964915288040585526471781869" }, "id": "CVE-2024-38605-f96b93e6", "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@39381fe7394e5eafac76e7e9367e7351138a29c1" } ] }