GHSA-2ccf-ffrj-m4qw
Suggest an improvement- Source
- https://github.com/advisories/GHSA-2ccf-ffrj-m4qw
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/04/GHSA-2ccf-ffrj-m4qw/GHSA-2ccf-ffrj-m4qw.json
- JSON Data
- https://api.osv.dev/v1/vulns/GHSA-2ccf-ffrj-m4qw
- Aliases
- Published
- 2023-04-21T22:32:47Z
- Modified
- 2023-11-08T04:12:16.480712Z
- Severity
-
- 6.5 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:N CVSS Calculator
- Summary
- CSRF token fixation in fastify-passport
- Details
-
The CSRF protection enforced by the
@fastify/csrf-protectionlibrary, when combined with@fastify/passport, can be bypassed by network and same-site attackers.Details
fastify/csrf-protectionimplements the synchronizer token pattern (using plugins@fastify/sessionand@fastify/secure-session) by storing a random value used for CSRF token generation in the_csrfattribute of a user's session.The
@fastify/passportlibrary does not clear the session object upon authentication, preserving the_csrfattribute between pre-login and authenticated sessions. Consequently, CSRF tokens generated before authentication are still valid. Network and same-site attackers can thus obtain a CSRF token for their pre-session, fixate that pre-session in the victim's browser via cookie tossing, and then perform a CSRF attack after the victim authenticates.Fix
As a solution, newer versions of
@fastify/passportinclude the configuration optionsclearSessionOnLogin (default: true)andclearSessionIgnoreFields (default: ['session'])
to clear all the session attributes by default, preserving those explicitly defined in
clearSessionIgnoreFields.Credits
- Pedro Adão (@pedromigueladao), Instituto Superior Técnico, University of Lisbon
- Marco Squarcina (@lavish), Security & Privacy Research Unit, TU Wien
- Database specific
{ "github_reviewed": true, "cwe_ids": [ "CWE-352" ], "github_reviewed_at": "2023-04-21T22:32:47Z", "nvd_published_at": "2023-04-21T23:15:20Z", "severity": "MODERATE" }- References
-
- https://github.com/fastify/fastify-passport/security/advisories/GHSA-2ccf-ffrj-m4qw
- https://nvd.nist.gov/vuln/detail/CVE-2023-29020
- https://github.com/fastify/fastify-passport/commit/07c90feab9cba0dd4779e47cfb0717a7e2f01d3d
- https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#synchronizer-token-pattern
- https://github.com/fastify/fastify-passport
- https://owasp.org/www-community/attacks/csrf
Affected packages
npm / @fastify/passport
Package
- Name
- @fastify/passport
- View open source insights on deps.dev
- Purl
- pkg:npm/%40fastify/passport
npm / @fastify/passport
Package
- Name
- @fastify/passport
- View open source insights on deps.dev
- Purl
- pkg:npm/%40fastify/passport