GHSA-4873-36h9-wv49

Suggest an improvement
Source
https://github.com/advisories/GHSA-4873-36h9-wv49
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/09/GHSA-4873-36h9-wv49/GHSA-4873-36h9-wv49.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-4873-36h9-wv49
Aliases
Published
2021-09-20T19:54:16Z
Modified
2024-11-19T18:23:04.977401Z
Severity
  • 6.3 (Medium) CVSS_V3 - CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:H/A:H CVSS Calculator
  • 5.8 (Medium) CVSS_V4 - CVSS:4.0/AV:L/AC:L/AT:P/PR:L/UI:N/VC:N/VI:H/VA:H/SC:N/SI:N/SA:N CVSS Calculator
Summary
Out-of-bounds read/write and invalid free with `externref`s and GC safepoints in Wasmtime
Details

Impact

There was an invalid free and out-of-bounds read and write bug when running Wasm that uses externrefs in Wasmtime.

To trigger this bug, Wasmtime needs to be running Wasm that uses externrefs, the host creates non-null externrefs, Wasmtime performs a garbage collection (GC), and there has to be a Wasm frame on the stack that is at a GC safepoint where

  • there are no live references at this safepoint, and
  • there is a safepoint with live references earlier in this frame's function.

Under this scenario, Wasmtime would incorrectly use the GC stack map for the safepoint from earlier in the function instead of the empty safepoint. This would result in Wasmtime treating arbitrary stack slots as externrefs that needed to be rooted for GC. At the next GC, it would be determined that nothing was referencing these bogus externrefs (because nothing could ever reference them, because they are not really externrefs) and then Wasmtime would deallocate them and run <ExternRef as Drop>::drop on them. This results in a free of memory that is not necessarily on the heap (and shouldn't be freed at this moment even if it was), as well as potential out-of-bounds reads and writes.

Even though support for externrefs (via the reference types proposal) is enabled by default, unless you are creating non-null externrefs in your host code or explicitly triggering GCs, you cannot be affected by this bug.

We have reason to believe that the effective impact of this bug is relatively small because usage of externref is currently quite rare.

Patches

This bug has been patched and users should upgrade to Wasmtime version 0.30.0.

Additionally, we have updated our primary externref fuzz target such that it better exercises these code paths and we can have greater confidence in their correctness going forward.

Workarounds

If you cannot upgrade Wasmtime at this time, you can avoid this bug by disabling the reference types proposal by passing false to wasmtime::Config::wasm_reference_types

References

For more information

If you have any questions or comments about this advisory:

Database specific
{
    "nvd_published_at": "2021-09-17T21:15:00Z",
    "cwe_ids": [
        "CWE-125",
        "CWE-590",
        "CWE-787"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2021-09-17T20:05:58Z"
}
References

Affected packages

crates.io / wasmtime

Package

Affected ranges

Type
SEMVER
Events
Introduced
0.26.0
Fixed
0.30.0

PyPI / wasmtime

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0.26.0
Fixed
0.30.0

Affected versions

0.*

0.26.0
0.27.0
0.28.0
0.28.1
0.29.0