In the Linux kernel, the following vulnerability has been resolved:
USB: Gadget: core: Help prevent panic during UVC unconfigure
Avichal Rakesh reported a kernel panic that occurred when the UVC gadget driver was removed from a gadget's configuration. The panic involves a somewhat complicated interaction between the kernel driver and a userspace component (as described in the Link tag below), but the analysis did make one thing clear: The Gadget core should accomodate gadget drivers calling usbgadgetdeactivate() as part of their unbind procedure.
Currently this doesn't work. gadgetunbinddriver() calls driver->unbind() while holding the udc->connectlock mutex, and usbgadget_deactivate() attempts to acquire that mutex, which will result in a deadlock.
The simple fix is for gadgetunbinddriver() to release the mutex when invoking the ->unbind() callback. There is no particular reason for it to be holding the mutex at that time, and the mutex isn't held while the ->bind() callback is invoked. So we'll drop the mutex before performing the unbind callback and reacquire it afterward.
We'll also add a couple of comments to usbgadgetactivate() and usbgadgetdeactivate(). Because they run in process context they must not be called from a gadget driver's ->disconnect() callback, which (according to the kerneldoc for struct usbgadgetdriver in include/linux/usb/gadget.h) may run in interrupt context. This may help prevent similar bugs from arising in the future.
{
"cna_assigner": "Linux",
"osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2023/53xxx/CVE-2023-53580.json"
}"https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2023-53580.json"
[
{
"id": "CVE-2023-53580-0be0196b",
"digest": {
"threshold": 0.9,
"line_hashes": [
"23970947880921882881142638440807898908",
"172205695813071860115195602676499666922",
"220280252787694031630160529124398898437",
"303701210123888573129919330680988412462",
"170593173338714892394266438704537644044",
"178659021226584926110915181160635064431",
"123903547499605854117488737772428735963",
"151482055804458863467744753075262857059",
"321259623794510329375378590395097717764",
"252415077660822319185005053979078236075",
"186849144840404615722954579352124581010"
]
},
"signature_type": "Line",
"target": {
"file": "drivers/usb/gadget/udc/core.c"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@bed19d95fcb9c98dfaa9585922b39a2dfba7898d",
"deprecated": false
},
{
"id": "CVE-2023-53580-1eee5625",
"digest": {
"length": 635.0,
"function_hash": "138134867618020195367311778159094160983"
},
"signature_type": "Function",
"target": {
"file": "drivers/usb/gadget/udc/core.c",
"function": "gadget_unbind_driver"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@8c1edc00db65f6d4408b3d1cd845e8da3b9e0ca4",
"deprecated": false
},
{
"id": "CVE-2023-53580-a0eff36a",
"digest": {
"threshold": 0.9,
"line_hashes": [
"23970947880921882881142638440807898908",
"172205695813071860115195602676499666922",
"220280252787694031630160529124398898437",
"303701210123888573129919330680988412462",
"170593173338714892394266438704537644044",
"178659021226584926110915181160635064431",
"123903547499605854117488737772428735963",
"151482055804458863467744753075262857059",
"321259623794510329375378590395097717764",
"252415077660822319185005053979078236075",
"186849144840404615722954579352124581010"
]
},
"signature_type": "Line",
"target": {
"file": "drivers/usb/gadget/udc/core.c"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@65dadb2beeb7360232b09ebc4585b54475dfee06",
"deprecated": false
},
{
"id": "CVE-2023-53580-ad99730a",
"digest": {
"length": 635.0,
"function_hash": "138134867618020195367311778159094160983"
},
"signature_type": "Function",
"target": {
"file": "drivers/usb/gadget/udc/core.c",
"function": "gadget_unbind_driver"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@65dadb2beeb7360232b09ebc4585b54475dfee06",
"deprecated": false
},
{
"id": "CVE-2023-53580-cac98b37",
"digest": {
"threshold": 0.9,
"line_hashes": [
"23970947880921882881142638440807898908",
"172205695813071860115195602676499666922",
"220280252787694031630160529124398898437",
"303701210123888573129919330680988412462",
"170593173338714892394266438704537644044",
"178659021226584926110915181160635064431",
"123903547499605854117488737772428735963",
"151482055804458863467744753075262857059",
"321259623794510329375378590395097717764",
"252415077660822319185005053979078236075",
"186849144840404615722954579352124581010"
]
},
"signature_type": "Line",
"target": {
"file": "drivers/usb/gadget/udc/core.c"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@8c1edc00db65f6d4408b3d1cd845e8da3b9e0ca4",
"deprecated": false
},
{
"id": "CVE-2023-53580-e77c5d1c",
"digest": {
"length": 635.0,
"function_hash": "138134867618020195367311778159094160983"
},
"signature_type": "Function",
"target": {
"file": "drivers/usb/gadget/udc/core.c",
"function": "gadget_unbind_driver"
},
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@bed19d95fcb9c98dfaa9585922b39a2dfba7898d",
"deprecated": false
}
]