In the Linux kernel, the following vulnerability has been resolved:
IB/hfi1: Fix sdma.h tx->num_descs off-by-one error
Unfortunately the commit fd8958efe877 introduced another error
causing the descs array to overflow. This reults in further crashes
easily reproducible by sendmsg system call.
[ 1080.836473] general protection fault, probably for non-canonical address 0x400300015528b00a: 0000 [#1] PREEMPT SMP PTI
[ 1080.974535] Call Trace: [ 1080.976990] <TASK> [ 1081.021929] hfi1ipoibsenddmacommon+0x7a/0x2e0 [hfi1] [ 1081.027364] hfi1ipoibsenddmalist+0x62/0x270 [hfi1] [ 1081.032633] hfi1ipoibsend+0x112/0x300 [hfi1] [ 1081.042001] ipoibstartxmit+0x2a9/0x2d0 [ib_ipoib]
[ 1081.148347] _syssendmsg+0x59/0xa0
crash> ipoibtxreq 0xffff9cfeba229f00 struct ipoibtxreq { txreq = { list = { next = 0xffff9cfeba229f00, prev = 0xffff9cfeba229f00 }, descp = 0xffff9cfeba229f40, coalescebuf = 0x0, wait = 0xffff9cfea4e69a48, complete = 0xffffffffc0fe0760 <hfi1_ipoib_sdma_complete>, packetlen = 0x46d, tlen = 0x0, numdesc = 0x0, desclimit = 0x6, nextdescqidx = 0x45c, coalesceidx = 0x0, flags = 0x0, descs = {{ qw = {0x8024000120dffb00, 0x4} # SDMADESC0FIRSTDESCFLAG (bit 63) }, { qw = { 0x3800014231b108, 0x4} }, { qw = { 0x310000e4ee0fcf0, 0x8} }, { qw = { 0x3000012e9f8000, 0x8} }, { qw = { 0x59000dfb9d0000, 0x8} }, { qw = { 0x78000e02e40000, 0x8} }} }, sdmahdr = 0x400300015528b000, <<< invalid pointer in the tx request structure sdmastatus = 0x0, SDMADESC0LASTDESC_FLAG (bit 62) complete = 0x0, priv = 0x0, txq = 0xffff9cfea4e69880, skb = 0xffff9d099809f400 }
If an SDMA send consists of exactly 6 descriptors and requires dword padding (in the 7th descriptor), the sdmatxreq descriptor array is not properly expanded and the packet will overflow into the container structure. This results in a panic when the send completion runs. The exact panic varies depending on what elements of the container structure get corrupted. The fix is to use the correct expression in _padsdmatxdescs() to test the need to expand the descriptor array.
With this patch the crashes are no longer reproducible and the machine is stable.
[
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5833024a9856f454a964a198c63a57e59e07baf5",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-18247b4d",
"signature_type": "Function",
"digest": {
"length": 428.0,
"function_hash": "314032220674053916590957780909910555188"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@115b7f3bc1dce590a6851a2dcf23dc1100c49790",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-210556a0",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3f38d22e645e2e994979426ea5a35186102ff3c2",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-4386d62b",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a2fef1d81becf4ff60e1a249477464eae3c3bc2a",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-693fbb62",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e6f57c6881916df39db7d95981a8ad2b9c3458d6",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-6ac05bee",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@5833024a9856f454a964a198c63a57e59e07baf5",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-6e721793",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@47ae64df23ed1318e27bd9844e135a5e1c0e6e39",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-72c6eaed",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@a2fef1d81becf4ff60e1a249477464eae3c3bc2a",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-9c905444",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@9034a1bec35e9f725315a3bb6002ef39666114d9",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-a2776ad6",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@52dc9a7a573dbf778625a0efca0fca55489f084b",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-c20b7944",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@e6f57c6881916df39db7d95981a8ad2b9c3458d6",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-c9eb59b1",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@9034a1bec35e9f725315a3bb6002ef39666114d9",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-cb9d8fd6",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@115b7f3bc1dce590a6851a2dcf23dc1100c49790",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-e440e778",
"signature_type": "Function",
"digest": {
"length": 428.0,
"function_hash": "314032220674053916590957780909910555188"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@47ae64df23ed1318e27bd9844e135a5e1c0e6e39",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-e8fb5310",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3f38d22e645e2e994979426ea5a35186102ff3c2",
"signature_version": "v1",
"deprecated": false,
"target": {
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-eeba324b",
"signature_type": "Line",
"digest": {
"threshold": 0.9,
"line_hashes": [
"337084570056983302587358679152055250746",
"11232926854329564823383709332273378274",
"94581400107806359869268756961926607585",
"104950455232506090586337109695067696785"
]
}
},
{
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@52dc9a7a573dbf778625a0efca0fca55489f084b",
"signature_version": "v1",
"deprecated": false,
"target": {
"function": "_pad_sdma_tx_descs",
"file": "drivers/infiniband/hw/hfi1/sdma.c"
},
"id": "CVE-2024-26766-f9f4372a",
"signature_type": "Function",
"digest": {
"length": 449.0,
"function_hash": "189489377110399344854480485606115755595"
}
}
]